fix(sandbox): reject stale exit during restart - #2857
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 21, 2026 01:47
|
Label |
9 tasks
This comment was marked as outdated.
This comment was marked as outdated.
pimlock
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent a delayed canonical-process exit from the stopped sandbox instance from racing with restart and moving the sandbox from
StartingtoError.The Kubernetes v1beta1 combined E2E reproduced the same failure twice on the unpatched commit:
Related Issue
No issue required: this is a localized lifecycle race with a focused regression test.
Changes
StartingTesting
mise run pre-commitpassescargo test -p openshell-server --libpasses (1,406 passed, 8 ignored)Checklist