Skip to content

fix(cli): prompt for fresh OIDC login after logout - #2773

Merged
sjenning merged 1 commit into
NVIDIA:mainfrom
grs:logout-fix
Aug 19, 2026
Merged

fix(cli): prompt for fresh OIDC login after logout#2773
sjenning merged 1 commit into
NVIDIA:mainfrom
grs:logout-fix

Conversation

@grs

@grs grs commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix OIDC logout/login behavior so openshell gateway logout causes the next browser-based openshell gateway login to request a fresh identity-provider prompt. This lets users switch browser identities instead of silently reusing the previous SSO session.

Related Issue

Changes

  • Added a per-gateway one-shot marker requesting prompt=login after OIDC logout.
  • Cleared the marker after a successful token store or gateway registration removal.
  • Updated the browser OIDC auth flow to append prompt=login when the marker is present.
  • Updated CLI help text and gateway auth docs to describe the fresh-login behavior.
  • Added unit coverage for marker lifecycle and authorization URL parameters.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • Manual testing

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Gordon Sim <gsim@redhat.com>
@grs
grs requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 17, 2026 11:20
@copy-pr-bot

copy-pr-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sjenning sjenning left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues.

I tested locally and it does work:

openshell gateway login (prompt page on OIDC provider)
openshell gateway login (skips prompt on OIDC provider and reauthenticates automatically)
openshell gateway logout
openshell gateway login (prompt page on OIDC provider)

@sjenning

Copy link
Copy Markdown
Collaborator

/ok to test 5bce638

@sjenning
sjenning added this pull request to the merge queue Aug 19, 2026
Merged via the queue into NVIDIA:main with commit 3a16012 Aug 19, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants