Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughMagpieTTS and NanoCodec now attempt integrated-GPU initialization after GPU initialization fails. The existing CPU fallback remains. The integrated-GPU attempt is skipped when CPU is forced. ChangesTTS backend fallback
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change adds an integrated-GPU attempt before the existing CPU fallback. No actionable merge-blocking risk is established by the available evidence. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: hsuanguo <hsuan.guo@gmail.com>
dbaab03 to
864559c
Compare
|
| if (!model.backend) { | ||
| model.backend = ggml_backend_init_by_type(GGML_BACKEND_DEVICE_TYPE_IGPU, nullptr); |
There was a problem hiding this comment.
IGPU allocation prevents CPU fallback
If an integrated GPU initializes but lacks enough memory for the model tensors, loading returns an error instead of trying the CPU backend. NanoCodec has the same path. Either failure stops synthesizer creation, even though the CPU fallback could have loaded the model. Retry loading on CPU when IGPU allocation fails, or check capacity before selecting the IGPU.
|
Can I know what is the hw platform you are trying to deploy this on? |
Hi, it's Jetson Orin on Jetpack 7.2 |
Got this error:
Add an IGPU initialization attempt after discrete-GPU initialization fails, before the existing CPU fallback, in both MagpieTTS and NanoCodec.