Update docstrings in validphys with new datasets names - #2490
Conversation
|
In general, if you are not doing a fit, then the fraction is not needed (since it is the training/validation split) RE legacy, use the variant that is used in the 4.1 runcard. If, for whataver reason, it cannot be used (e.g. it is an example that only runs for older theories and data for some reason) then use legacy. |
|
Regarding datasets that are not in the |
I'd say the closest one. But again, if it is an exmaple, you can choose a different dataset and make sure that the example is showing the same. |
|
Hi @kamillaurent is this complete? |
|
I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff |
1 similar comment
|
I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff |
|
@scarlehoff now it should be ok. Let me know if this PR can be merged or needs some other change. |
|
Thanks, let's wait for #2499 to merge since this affects doctests so better to rebase on top of that one so this is merged tested. |
I am still not sure when to add
"variant": "legacy"and"frac": 0.75when switching names.