Skip to content

Update docstrings in validphys with new datasets names - #2490

Merged
scarlehoff merged 10 commits into
masterfrom
update_docstrings_vp-new_datasets_names
Sep 2, 2026
Merged

Update docstrings in validphys with new datasets names#2490
scarlehoff merged 10 commits into
masterfrom
update_docstrings_vp-new_datasets_names

Conversation

@kamillaurent

Copy link
Copy Markdown
Contributor

I am still not sure when to add "variant": "legacy" and "frac": 0.75 when switching names.

@kamillaurent
kamillaurent requested a review from scarlehoff July 1, 2026 12:18
@kamillaurent kamillaurent self-assigned this Jul 1, 2026
@scarlehoff

Copy link
Copy Markdown
Member

In general, if you are not doing a fit, then the fraction is not needed (since it is the training/validation split)

RE legacy, use the variant that is used in the 4.1 runcard. If, for whataver reason, it cannot be used (e.g. it is an example that only runs for older theories and data for some reason) then use legacy.

@kamillaurent

Copy link
Copy Markdown
Contributor Author

Regarding datasets that are not in the dataset_names.yml (i.e. NTVNUDMNFe from validphys2/src/validphys/n3fit_data.py), should I remove them or should I change them with the closest name (in this case NTVNUDMNFe_dw_ite)?

@scarlehoff

Copy link
Copy Markdown
Member

should I remove them or should I change them with the closest name (in this case NTVNUDMNFe_dw_ite)?

I'd say the closest one.

But again, if it is an exmaple, you can choose a different dataset and make sure that the example is showing the same.

@scarlehoff

Copy link
Copy Markdown
Member

Hi @kamillaurent is this complete?

@kamillaurent

Copy link
Copy Markdown
Contributor Author

I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff

1 similar comment
@kamillaurent

Copy link
Copy Markdown
Contributor Author

I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff

Comment thread validphys2/src/validphys/theorycovariance/higher_twist_functions.py
Comment thread validphys2/src/validphys/pseudodata.py Outdated
Comment thread validphys2/src/validphys/utils.py Outdated
@kamillaurent

Copy link
Copy Markdown
Contributor Author

@scarlehoff now it should be ok. Let me know if this PR can be merged or needs some other change.

@scarlehoff

Copy link
Copy Markdown
Member

Thanks, let's wait for #2499 to merge since this affects doctests so better to rebase on top of that one so this is merged tested.

@scarlehoff scarlehoff added the Done PRs that are done but waiting on something else to merge/approve label Aug 29, 2026

@scarlehoff scarlehoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@scarlehoff
scarlehoff merged commit f4cbc24 into master Sep 2, 2026
24 of 26 checks passed
@scarlehoff
scarlehoff deleted the update_docstrings_vp-new_datasets_names branch September 2, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done PRs that are done but waiting on something else to merge/approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants