Skip to content

Fix code-quality CI: resolve npm peer conflict from TypeScript 7 bump - #287

Merged
smokhov merged 1 commit into
dependabot/npm_and_yarn/src/java/ws/rest-client/typescript-7.0.2from
copilot/fix-github-actions-job-code-quality
Oct 2, 2026
Merged

smokhov merged 1 commit into
dependabot/npm_and_yarn/src/java/ws/rest-client/typescript-7.0.2from
copilot/fix-github-actions-job-code-quality

Conversation

Copilot AI commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

npm ci in src/java/ws/rest-client fails in the code-quality (22.x) job. The TypeScript 7.0.2 bump conflicts with the peer range typescript >=6.0 <6.1 that the Angular build tooling declares.

This PR does not move TypeScript up. It pins typescript to ~6.0.3 and updates the surrounding dependencies. TypeScript 7 cannot be adopted with current releases, so this is a stopgap until upstream support lands.

  • Why 7.x isn't viable yet

    • @angular/compiler-cli, @angular/build and @angular-devkit/build-angular (latest 22.2.1, and 22.3.0-next.0) all declare typescript >=6.0 <6.1. typescript-eslint caps at <6.1.
    • An npm overrides entry for typescript lets npm install succeed, but both tools then fail at runtime:
      • ng build: Cannot read properties of undefined (reading 'Error')
      • ng lint: Cannot read properties of undefined (reading 'Intrinsic')
    • TypeScript 7 is the native compiler and no longer provides the JavaScript API these tools call.
    • Aliasing @typescript/typescript6 for the tooling via overrides doesn't work either. npm requires the root package to satisfy each peer dependency.
  • package.json and package-lock.json

    • typescript: ~7.0.2 → ~6.0.3
    • @angular/* and @angular-devkit/build-angular: aligned to ^22.2.1. This also fixes a @angular/common 22.1.1 vs @angular/core peer mismatch.
    • angular-eslint: 22.1.0 → ^22.5.0
    • typescript-eslint: 8.65.0 → ^8.71.0

Follow-up: move to TypeScript 7 once Angular and typescript-eslint publish versions that support it.

Co-authored-by: smokhov <10067003+smokhov@users.noreply.github.com>
@smokhov
smokhov added this pull request to stack #288 October 2, 2026 20:11
@smokhov
smokhov marked this pull request as ready for review October 2, 2026 20:12
@smokhov
smokhov merged commit 27e0cbb into integration Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants