Added NotifyMatchType to OnNotifyFromActor - #391
Open
fede-Raider wants to merge 6 commits into
Open
Conversation
UFlowNode_ComponentObserver: fix SuccessCount persistence on save during Success flow
Introduced a EFlowTagMatchType, replacing the hardcoded exact-match check with a configurable one. This allows the node to listen for a parent Notify Tag and match against any of its child tags, instead of requiring an exact tag match.
Fixed Automerge
EFlowTagMatchType::HasExact as Default value of NotifyMatchType
fede-Raider
commented
Sep 9, 2026
| } | ||
|
|
||
| if (IdentityMatches && (!NotifyTags.IsValid() || NotifyTags.HasTagExact(Tag))) | ||
| const bool IdentityMatches = FlowTypes::HasMatchingTags(Component->IdentityTags, IdentityTags, IdentityMatchType); |
Contributor
Author
There was a problem hiding this comment.
Use of already existing utility function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
NotifyMatchType(EFlowTagMatchType) property toUFlowNode_OnNotifyFromActor, letting users choose how the NotifyTag should be matched.Motivation
Previously,
OnNotifyFromComponentmatched NotifyTags usingNotifyTags.HasTagExact(Tag), which only accepted exact tag matches.This made it impossible to set up a node listening for a parent tag (e.g.
Notify.Interaction) that should trigger on any of its children (e.g.Notify.Interaction.Pickup,Notify.Interaction.Use).Changes
EFlowTagMatchTypetype.EFlowTagMatchType NotifyMatchTypeproperty toUFlowNode_OnNotifyFromActor.NotifyTags.HasTagExact(Tag)withFlowTypes::HasMatchingTag(Tag, NotifyTags, NotifyMatchType), mirroring the existing pattern already used forIdentityMatchType.Testing
NotifyMatchTypeis set toHasExact(default value).NotifyMatchTypeis set toHas.