fix(select): show popover-hosted menus above their parent - #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select menus inside a MoonPopover were painted beneath their parent, hiding placement choices. Add an explicit MoonSelect::in_popover() opt-in backed by a configurable base menu layer; ordinary selects keep their existing layer.
Validation: full MoonUI guardrails passed (454 component tests and 7 gallery tests), scene-order regression passed in light/dark themes and failed when forwarding was removed, and the shipped MoonTerminal executable was checked with mouse and keyboard. API and donor snapshots include only the intended additions.
CI waiting is explicitly waived by the maintainer for this change.