Spell out the operation of the quantified comparison bare names - #144
Merged
estebanzimanyi merged 1 commit intoSep 13, 2026
Conversation
MobilityDB declares the functions behind the ever, always and temporal comparison operators with their operation spelled out: eEqual, eNotEqual, eLessThan, eLessEqual, eGreaterThan and eGreaterEqual, and the same behind a for always and t for the temporal comparison (MobilityDB#2710), since eLt is the built-in elt of Apache Spark and Apache Flink, which read a function name whatever its case. The three comparison families of meta/portable-aliases.json carry these 18 names for the same 18 operators, so the catalog's byOperator and byBareName, and every binding generated from them, name the functions as MobilityDB declares them. The tests read the new names, and the catalog example of docs/portable-aliases.md reads the values the catalog holds: tEqual for #=, the sorted bare names from aEqual to tNotEqual, and 41 aliases. Measured over MobilityDB master 129433dbfd with the catalog derived from the repository root: 41 portable aliases, with ?= mapping to eEqual, %>= to aGreaterEqual and #<> to tNotEqual; test_portable.py and test_portable_parity.py read 16 of 16, the live parity gate included. With the same catalog the full suite reads 6 failed, 321 passed and 24 skipped on this branch and on master alike: the six, the coverage gate, the family classification and four struct layouts, read a built libmeos, which the tests workflow builds before it derives the catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB declares the functions behind the ever, always and temporal
comparison operators with their operation spelled out: eEqual, eNotEqual,
eLessThan, eLessEqual, eGreaterThan and eGreaterEqual, and the same behind a
for always and t for the temporal comparison (MobilityDB#2710), since eLt is
the built-in elt of Apache Spark and Apache Flink, which read a function name
whatever its case.
The three comparison families of meta/portable-aliases.json carry these 18
names for the same 18 operators, so the catalog's byOperator and byBareName,
and every binding generated from them, name the functions as MobilityDB
declares them. The tests read the new names, and the catalog example of
docs/portable-aliases.md reads the values the catalog holds: tEqual for #=,
the sorted bare names from aEqual to tNotEqual, and 41 aliases.
Measured over MobilityDB master 129433dbfd with the catalog derived from the
repository root: 41 portable aliases, with ?= mapping to eEqual, %>= to
aGreaterEqual and #<> to tNotEqual; test_portable.py and
test_portable_parity.py read 16 of 16, the live parity gate included. With
the same catalog the full suite reads 6 failed, 321 passed and 24 skipped on
this branch and on master alike: the six, the coverage gate, the family
classification and four struct layouts, read a built libmeos, which the tests
workflow builds before it derives the catalog.