fix: support localized lens and billing pages - #187
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes update lens parsing for localized markup and usage parsing for plans without AI cost tracking and Norwegian billing labels. Tests, command documentation, and the unreleased changelog reflect these behaviors. ChangesLocalized parsing fixes
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Localized lens and billing parsing behavior is covered without an identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92fc5e680c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Note 🤖 GPT-5 responding on behalf of Microck this warning treats the abbreviated HTML excerpt in #186 as the full page. the excerpt contains the existing plan parser is therefore working against the full live page. adding a fallback for any standalone |
92fc5e6 to
f1e8451
Compare
f1e8451 to
35dea27
Compare
Summary
localized Kagi accounts broke every lens command that needs the edit URL, and Starter plan accounts could not use
kagi usageat all.this reads lens edit links from their stable route, treats the plan-specific AI cost box as optional, and recognizes the Norwegian balance and renewal labels reported in the issues.
Closes #185.
Closes #186.
Verification
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo test --workspace --all-targets --locked(317 passed, 13 credential-gated tests ignored)"ai_cost": nullpnpm buildfromdocs/(44 static pages)(cd npm && npm pack --dry-run)Docs
Auth / secrets
AI assistance
agent_name: OpenAI Codexagent_version: codex-cli 0.154.0model_used: GPT-5human_testing: issue reporter Terje Pettersen manually testedlens listandlens geton a Norwegian-locale account as documented in [bug] lens list/get fails: .lens_edit_lens wrapper removed and aria-labels localized #185, and testedusageon a Norwegian-locale Starter account as documented in [bug] usage hard-fails on Starter plan (no AI-cost box) and localized labels #186. The local checks listed above were run by OpenAI Codex, not a human.contribution_summary: fixed localized lens edit-link parsing and billing usage parsing for plans without AI cost tracking.Summary by CodeRabbit
Bug Fixes
kagi usagenow supports plans without AI cost tracking.Documentation
kagi usagedocumentation to explain when AI cost fields appear in JSON responses.