Repository navigation
fix: keep bytes that arrive with the HTTP proxy's CONNECT response - #3382
Merged
wwqgtxx merged 1 commit intoOct 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shakeHandContextreads the CONNECT response through abufio.Readerand then drops the reader. If the proxy writes the target's first bytes right behind its200response, they can arrive in the same read and stay in the dropped buffer. Server-first protocols such as SSH or SMTP then lose their banner and the connection hangs.The reader is now created in
StreamConnContextand passed to the handshake.N.WarpConnWithBioReaderputs the buffered bytes in front of the returned connection, and returns the connection unchanged when nothing is buffered.To reproduce, put an HTTP proxy outbound in front of a server that speaks first, and have the proxy send
HTTP/1.1 200 Connection established\r\n\r\nand the server's first bytes in one write. The client never receives those bytes.