Repository navigation
Fix the license mismatch and fill in the package.json metadata - #9
Merged
Merged
Conversation
`package.json` carried `"license": "ISC"`, the `npm init` default, while LICENSE.md holds the MIT text and the README says MIT. MIT is the intent, so the manifest now says so.
Both were still the `npm init` defaults. The description follows the README's opening line; the author matches the identity on every commit in the repo.
Megapixel99
changed the title
Megapixel99
force-pushed
the
fix/license-mismatch-mit
branch
from
August 21, 2026 14:48
5ea6859 to
bf0467b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsonstill carried threenpm initdefaults:"license": "ISC","description": "", and"author": "".The license one was an actual inconsistency —
LICENSE.mdat the repo root holds the MIT text and the README's License section says MIT, so the manifest contradicted both. It now says"license": "MIT". No license text changes.The other two are filled in to match what the repo already says about itself:
Seth Wheeler <23089578+Megapixel99@users.noreply.github.com>, the identity on all 42 commits in the repo.On renaming
LICENSE.mdtoLICENSEConsidered and skipped. GitHub already resolves the current filename —
gh repo view Megapixel99/nodejs-k8s --json licenseInforeturns{"key":"mit","name":"MIT License"}, so the sidebar picks it up as-is. Renaming would only invalidate the README'ssee \LICENSE.md`` reference for no gain.Context: found while preparing a submission to sindresorhus/awesome-nodejs, where a clearly stated license and populated metadata are worth having.
🤖 Generated with Claude Code