feat: take peripherals at launch when a marked display is connected - #121
Merged
Merged
Conversation
A marked display that was already connected when Magic Switch started used to be treated as the baseline and never triggered a switch. Now the monitor starts from an empty set and reconciles after the usual debounce, so launching while docked takes the peripherals like a fresh dock. The existing guards still apply: nothing happens if they're already here, Bluetooth is unhealthy, or a switch is in flight.
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A marked display that was already connected when Magic Switch started used to be treated as the baseline and never triggered a switch. Now the monitor starts from an empty set and reconciles after the usual debounce, so launching while docked takes the peripherals like a fresh dock.
The existing guards in
takeAllPeripheralsIfAwaystill apply: it's a silent no-op if the peripherals are already here, if Bluetooth is unhealthy, or if a switch is in flight.Trade-off: restarting the app while docked (e.g. after an update) now pulls peripherals back even if they were deliberately sent to the other Mac.
README updated to match.