chore: set the App Store category and clear compiler warnings - #116
Merged
Merged
Conversation
App Store validation rejects archives without LSApplicationCategoryType, so declare the app as a utility. Also fix the two remaining compiler warnings in BluetoothPeripheralStore: a never-mutated var, and a pairing callback whose inner [weak self] conflicted with an implicit strong capture in the enclosing closure.
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LSApplicationCategoryType=public.app-category.utilitiestoInfo.plist. App Store validation rejects archives without it.BluetoothPeripheralStore.swift:newPeripheralis never mutated, so it's nowlet.DispatchQueue.main.asyncnow captures[weak self], matching the inner closure and the rest of the file.