Repository navigation
test: shared Windows/Mac fixtures for view math, zoom controller and view owner - #547
Merged
Merged
Conversation
Maxaubert
force-pushed
the
test/shared-fixtures
branch
from
November 4, 2026 20:59
07ad140 to
631c8b7
Compare
…view owner (#546) tests/fixtures/shared/ holds language-neutral cases (one per line, tagged all/win/mac) that tests/test_shared_fixtures.cpp and mac/Tests/WindCoreChecks/SharedFixtures.swift both run. The all and win values come from the C++ code; WIND_UPDATE_FIXTURES=1 rewrites them. Deliberate differences (the wheel glide path, keyboard pan speed, setLevel during the ease-out, the Mac-only still view) are per-platform rows. mac.yml now also runs on changes to the shared folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP
) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP
Maxaubert
force-pushed
the
test/shared-fixtures
branch
from
November 4, 2026 21:52
631c8b7 to
8b5ed72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #546.
What
tests/fixtures/shared/:view_math_cases.txt(clamp, edge pan with cursor bodies, track target, key pan speed, still view),zoom_controller_cases.txt(direction, notch step, quick zoom, hold, clamps, release ease-out, accel ramp, wheel targets),view_owner_cases.txt(StepViewOwner step sequences). One case per line,=tokens are expectations, fixed tolerance 1e-6 (documented in each header).tests/test_shared_fixtures.cpp(doctest, no<windows.h>; picked up bybuild.bat'stests\*.cpp). Runsallandwinrows;WIND_UPDATE_FIXTURES=1rewrites them from the C++ code.mac/Tests/WindCoreChecks/SharedFixtures.swift, registered inmain.swift; finds the folder four levels up from#filePath. Runsallandmacrows.mac.yml: push and pull_request path filters includetests/fixtures/shared/**.mac/docs/architecture.md.Deliberate differences (per-platform rows, not forced to agree)
setLevel(2)5 ticks into the release ease-out: Windows 2.0876 (rate keeps decaying), Mac 2 (setLevel stops it).stillViewTargetis Mac-only; WindowsEdgePanCenter's MPO wall is not ported (shared rows pass -1).Tests
build.bat test: 675/675 test cases pass.all/macrows agree); the mac job is the real check.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP