Repository navigation
refactor(ui): shared settings files in ui-shared (#544) - #545
Merged
Merged
Conversation
Toggle, bindings.css, icons, themes (and gen-themes.cjs), dialog.js, ThemePicker, search.js, Banner, Card and ScrollChip were byte-identical in ui/ and mac/ui/. They move to ui-shared/src, imported as $shared/... through a Vite alias (svelte deduped to each app's copy). The Mac copy of gen-flyout-palettes.cjs is dropped: it writes a Windows file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP
Maxaubert
force-pushed
the
ui/shared-core
branch
from
November 4, 2026 21:44
f1318ba to
dd2e8ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #544.
The 11 settings UI files that were byte-identical in
ui/(Windows) andmac/ui/(Mac), plus the theme generator, now live once inui-shared/. Net: 1102 lines removed, 105 added.controls/Toggle.svelte,controls/bindings.css,design/icons.js,design/themes.css,design/themes.js,lib/dialog.js,prefs/ThemePicker.svelte,search/search.js,shell/Banner.svelte,shell/Card.svelte,shell/ScrollChip.svelte,tools/gen-themes.cjs.$shared/...through a Vite alias, withsveltededuped to each app's own copy. Imports insideui-sharedstay relative. Node tests use relative paths.gen-flyout-palettes.cjs, which writes a Windows file.mac.ymlruns onui-shared/**, andbuild.yml/release.ymlalready do. Path fixes:test_flyout_palettes.cpp, the copyright gate's generated list, docs, CLAUDE.md files, andui-shared/README.md.App.svelte(identical, but it's the app entry),public/c-grey.jpg(each app's public dir), lockfiles, and all near-identical files (stage 2).Verified on Windows:
ui/: build, test:rules, Playwright 218/218.mac/ui/: build, test:rules 15/15, Playwright Chromium 139/139. WebKit isn't installed on this PC; themacCI job runs it.build.bat test(palette test reads the moved themes.css),build.bat config, copyright gate.Mac session: please run
scripts/build.shon the Mac once this is merged.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kg7JN6HgdB9FaHJsgLxovP