Repository navigation
feat: add joinHostPort template function - #491
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Add joinHostPort template function using net.JoinHostPort to consistently format network addresses for IPv4, IPv6, and hostnames. Register the function in GenericFuncMap and add regression tests covering IPv4, IPv6, and hostname inputs. Fixes Masterminds#472
Author
|
Closing in favor of earlier community PR #477 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
joinHostPorttemplate function to format network addresses using Go standard librarynet.JoinHostPort(fmt.Sprint(host), fmt.Sprint(port)).Details
joinHostPort(host, port interface{}) stringinnetwork.gousingnet.JoinHostPort."joinHostPort": joinHostPortinGenericFuncMap().docs/network.mdanddocs/index.md.network_test.gocovering IPv4 (127.0.0.1,8080), IPv6 (::1,443), and hostname (localhost,"http") with direct invocation and template pipeline execution.Fixes #472