Repository navigation
fix: make ^* match any version - #319
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
The caret docs say ^* means any, but parsing rewrote it to dirty 0.0.0 and constraintCaret fell through to patch equality, so only 0.0.0 matched. Treat a fully-wildcard caret the same as the documented "any" case. Exact ^0.0.0 is unchanged. Fixes Masterminds#317
|
Thanks for picking this up. I ran an independent follow-up check against this PR at Besides the original stable I recorded the small CI-backed check here in case it is useful: Just sharing this as supporting validation for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment on
constraintCaretsays^* --> (any), but^*only matched0.0.0.Parsing turns
^*into dirty0.0.0with neither minor nor patch dirty, then the caret logic fell through to a patch equality check. This treats that fully-wildcard form as "any", which matches the docs. Exact^0.0.0is still not dirty, so it keeps meaning>=0.0.0 <0.0.1.Fixes #317