fix(dev): stop .env.example pinning the web app to dead fixed ports - #842
fix(dev): stop .env.example pinning the web app to dead fixed ports#842JeremyFunk wants to merge 1 commit into
Conversation
bun dev derives VITE_API_BASE_URL and VITE_ELECTRIC_SYNC_URL from the portless routes, but vite.config.ts only fills them when unset. The template still set the pre-alchemy fixed ports (3472, 3476), so any .env.local copied from it sent every web API call to a closed port.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ChangesWeb app environment configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The example configuration now leaves the raw-port overrides unset as intended and presents no actionable merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bun devderivesVITE_API_BASE_URL/VITE_ELECTRIC_SYNC_URLfrom portless routes, butapps/web/vite.config.tsuses??=, so a set value wins.env.examplestill set the pre-alchemy fixed ports (localhost:3472,:3476); nothing listens there underbun dev.env.localcopied from the template → every web API callERR_CONNECTION_REFUSED, app shows "Failed to load environments"VITE_INGEST_URL); drop the reference to the removedbun dev:portlessscriptNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
bun devand portless routes.