Repository navigation
fix(transport): never resend a timed-out POST and retry busy idempotent requests - #12
Merged
Merged
Conversation
…nt requests Retry 429 and 503 on GET, PUT and DELETE after the Retry-After wait, keep the error code of downloads, and add the opt-in list envelope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A POST that times out after it was sent is no longer sent again, so an upload cannot make a duplicate submission. GET, PUT and DELETE requests and downloads retry on 429 and 503 after the Retry-After wait, at most 60 seconds and
max_retriestimes. Download errors keep their error code.Also adds
list_envelope=True(opt-inenvelope=1), the total of the SHA256 search, andattributionon the exfil request list. The fake API supports the envelope. Tests use mock transports, no network calls.