Repository navigation
Conversation
Why are these changes being introduced: * Fulltext fields are very large blocks of text compared to other metadata-only fields. * Reducing the boost for fulltext fields ensures that matches in smaller, more specific metadata fields are not overshadowed by matches in large text blocks. * We had evidence that relevance scores as measured by Quepid were being negatively affected under some conditions. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-723 How does this address that need: * Reduced the boost for fulltext fields in the search query.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The boost change and corresponding test update are reviewed with no unresolved issues.
0 open findings
What changed in this PR
Reduces the relevance boost for fulltext matches so more specific metadata fields rank higher.
Changes:
- Applies a
0.1boost tofulltext. - Updates the query-builder test expectation.
| File | Summary |
|---|---|
test/models/lexical_query_builder_test.rb |
Verifies the updated field boost. |
app/models/lexical_query_builder.rb |
Lowers the fulltext field boost. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO