Repository navigation
Filament vectorization and avoiding OFT imports - #16
Merged
Merged
Conversation
ZanderKeith
force-pushed
the
zk/filament-vec
branch
2 times, most recently
from
September 15, 2026 19:03
4833726 to
ca3f7db
Compare
ZanderKeith
force-pushed
the
zk/filament-vec
branch
from
September 16, 2026 20:00
ca3f7db to
b00275a
Compare
chandrarn
reviewed
Sep 16, 2026
chandrarn
left a comment
chandrarn
left a comment
Collaborator
There was a problem hiding this comment.
A few minor comments, pytest passes with the odd from OpenFUSIONToolkit._core import OFT_env change.
Collaborator
There was a problem hiding this comment.
See note to PR #15: proposing to change to PyPi implementation of OFT, instead of Git binary version, and move the install requirement to pyproject.toml
chandrarn
approved these changes
Sep 18, 2026
chandrarn
left a comment
chandrarn
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Comments all cleared up, new vectorization is clear and readable.
OFT PyPi switchover will be handled in a separate PR, along with the switch to normalized surface-current-density instead of normalized current magnitude
Collaborator
Author
|
This PR also merged in changes discussed here: #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some simple changes which improve filament tracing / Biot-Savart performance, as well as avoiding expensive OFT imports when it isn't needed for the trace.