Repository navigation
TARS refactor - #13
Conversation
…on points to prevent synthetic structures
…equilibrium filament tracer tests pass, removed check for coprime number of filaments
chandrarn
left a comment
chandrarn
left a comment
There was a problem hiding this comment.
Looks good overall.
There were a few small errors in pytest: considering the case which neither the TCV nor DIII-D equilibria is available for a user to test, more robust protection for only creating one oft_env object, and changing the way resistivity_list within gen_OFT_filament_and_eta_file is handled (modern OFT introduces breaking changes disallowing more resistive elements than mesh "groups" present in the .h5 file. The script currently implicitly assumed that you needed one resistivity value per filament. The changes do not impact legacy OFT versions).
I am opening a PR on this branch, which should automatically update with the intended changes. Once that's accepted, I'll accept this as well.
* Commit with pytest corrections, for merging into zk/tars-refactor. Very small modification to .pre-commit-config.yaml to prevent uv synch checks from blocking push, necessary to deal with different OFT install methods * no pdfs in .gitignore * Removed PDFs --------- Co-authored-by: ZanderKeith <zkeith@mit.edu>
|
Addressed lingering items from #14, after CI passes will squash and merge. |
…nce in updated ThinCurr
2 participants
Modifications for the refactor of TARS
Major changes:
mirnov.synthetic_signalfor getting direct responses via Biot-Savart (fast), direct responses via ThinCurr (slower, mostly for testing consistency with Biot-Savart method), and frequency responses via ThinCurr (for vessel correction)detect_cocosto clearly state its limitations (cannot actually differentiate between odd vs even, must assume)detect_cocosworks on C-Mod, DIII-D, and TCV shots.EquilibriumField.qpsinow matches COCOS sign, can query newqpsi_abswhen working with |q|