Repository navigation
ADR 0201 slice 5: ADR 0030 proposes the anon/ move and corrects its harness-import sentence (BACKLOG #1192) - #2580
Conversation
Documentation only. ADR 0030 gains a dated status-banner amendment recording ADR 0201 section 5: the package's home is planned to become messagefoundry_toolkit/anon/, the rule table stays the single authority with a tee copy, the parity check re-points in slice 6, and the CLAUDE.md section 4 carve-out extension to anon/ is withdrawn. Nothing moves; every path in ADR 0030 still describes the tree until slice 6. Corrects ADR 0030 section 1, which said the harness imports the package directly. No harness file does, per the owner ruling of 2026-10-12 (BACKLOG #3006 part 3); the old sentence is kept as a record. The ADR index row for 0030 records the amendment. No new ADR number. BACKLOG #1192 Proposed PR title: ADR 0201 slices 3 and 5: the toolkit name is published, and ADR 0030 records the planned anon/ move (BACKLOG #1192) Proposed ledger banner: #1192: ADR 0201 slices 3 and 5 built (the install-provenance guard lists messagefoundry-toolkit as published after a PyPI probe with a control; ADR 0030 amended for the planned anon/ move, with the harness-import sentence corrected). Slices 4, 6, 7 and the release-gated 15.2.3 re-score (slice 8) remain.
…markers /simplify findings on the ADR 0030 amendment. The harness-import correction was stated in the status banner and again in section 1; the banner now points to section 1. The Related line, section 1 and the To resolve item still read as extending the parsing/ carve-out to anon/, so each carries a short withdrawn marker. The ADR index row's amendment note is cut to one clause. BACKLOG #1192 Proposed PR title: ADR 0201 slices 3 and 5: the toolkit name is published, and ADR 0030 records the planned anon/ move (BACKLOG #1192) Proposed ledger banner: #1192: ADR 0201 slices 3 and 5 built (the install-provenance guard lists messagefoundry-toolkit as published after a PyPI probe with a control; ADR 0030 amended for the planned anon/ move, with the harness-import sentence corrected). Slices 4, 6, 7 and the release-gated 15.2.3 re-score (slice 8) remain.
ADR 0201 section 5 says changing ADR 0030's ratified home needs the owner's sign-off on its own, so the banner bullet is now a PROPOSED amendment awaiting that sign-off, and each carve-out marker says "withdrawal proposed" (section 8 gains one; the Related-line marker sits on the carve-out clause, not the one-way rule). The harness correction: section 1 now says CaptureSink anonymizes only when its caller passes a function, and the shipped capture command passes none; the Context bullet and "The harness is unaffected" carry markers. Item 2 notes that not every tee file is byte-identical. The index row says the ADR has earlier amendments. test_dependency_boundaries' advice and comment no longer cite section 1 as allowing the harness import. BACKLOG #1192 Proposed PR title: ADR 0201 slice 5: ADR 0030 proposes the anon/ move and corrects its harness-import sentence (BACKLOG #1192) Proposed ledger banner: #1192: ADR 0201 slice 5 built (ADR 0030 carries a proposed amendment for the anon/ move, awaiting the owner's sign-off on this PR, and its harness-import sentence is corrected). Slice 3 is on its own PR; slices 4, 6, 7 and the release-gated 15.2.3 re-score (slice 8) remain.
|
QA -- korus roles/BUILDER.md step 11 (BACKLOG #1192, slices 3 and 5, one review over both) |
|
Lander (session 8a04c9f3), 2026-10-28. Enqueuing at pinned head Review proof: the Builder's QA line (xhigh, two rounds, review_tag.py exit 0). All nine required contexts are completed and successful on this head. Open findings, each filed on vault
|
Merge danger
Reversible: yes -- a revert of the squash commit undoes all of it. Docs and one test-string change only; no code moves.
Blast radius:
docs/adr/0030-anonymization-test-harness-tee.md,docs/adr/README.md(the 0030 index row), and the_REAL_ANON_IMPORT_ADVICEstring plus its comment intests/test_dependency_boundaries.py._ANON_MODULEis untouched andanon/does not move.Evidence
messagefoundry.anondirectly. No harness file does, and the owner ruling of 2026-10-12 (BACKLOG #3006 part 3) records that. ADR 0030 also carried no record of ADR 0201's planned move ofanon/intomessagefoundry_toolkit.Why this is its own pull request
ADR 0201 section 5 says the ADR 0030 amendment "lands in its own PR" and "needs the owner's sign-off on its own, not buried in a mechanical diff". Section 7 says each slice is one PR. The rest of batch 448's engine work rides the batch PR.
BACKLOG #1192, ADR 0201 slice 5 (batch 448)
b448-1192-slice-5, heade110c3a2c939987ef3ec5e12a61fbc159ac3a894, base origin/main4e52f4ede.What changed
messagefoundry_toolkit/anon/; the rule table stays the single authority and the tee still vendors a copy (not every file byte-identical;tests/test_anon_parity.pyrecords which are); the parity check re-points in slice 6; the extension of the CLAUDE.md section 4 carve-out toanon/is withdrawn (it never landed).CaptureSinkanonymizes only when its caller passes an anonymizer; the shippedpython -m harness.reconcile capturepasses none.Owner action
The amendment is marked PROPOSED. The owner's sign-off is what ADR 0201 section 5 asks for; whoever records it edits that banner bullet.
Open review findings (round 2, shipped per korus BUILDER.md 4c)
raw, which section 1 now contradicts. The contradiction pre-existed; this change made it visible. Section 6 carries no marker. This one needs a follow-up row: an unmarked section 6 could lead a reader to run capture against real traffic._REAL_ANON_IMPORT_ADVICEwording "its correction says none does" sits oddly inside a failure that just found an import.Unread legs
None specific; read the required contexts as usual.
Proposed ledger banner (#1192)
Carried verbatim from the branch's final commit message for the Lander.


Confidence Score: 5/5
The reviewed changes appear safe to merge, with the move still explicitly pending the owner’s sign-off.Summary
ADR 0030 now proposes moving
anon/intomessagefoundry_toolkit/anon/, pending the owner’s sign-off. It also corrects the harness-import claim and updates the ADR index and boundary-test advice.Reviews (1) · Last reviewed commit: "ADR 0201 slice 5: code-review round 1 re..." · Reviewed by Greptile