Skip to content

fix: explain the Ctrl+K / ⌘K search shortcut hint (WCAG 3.3.2) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenlhlui merged 1 commit into from
Oct 13, 2026
Merged

fix: explain the Ctrl+K / ⌘K search shortcut hint (WCAG 3.3.2) #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _layouts/minimal_search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ <h1><a href="{{ '/' | relative_url }}"><span aria-hidden="true">📚 </span>Lear
<label for="searchInput" class="search-label">Search guides</label>
<div class="search-field">
<input type="search" id="searchInput" enterkeyhint="search" autocomplete="off" placeholder="Title, topic, tool, series…" aria-keyshortcuts="Control+K Meta+K">
<span class="search-hint" aria-hidden="true">Ctrl+K</span>
<span class="search-hint" aria-hidden="true">Press <kbd>Ctrl+K</kbd> to search</span>
</div>
</div>
<!-- Sits in the bar rather than floating over the results: the bar no
Expand Down
6 changes: 5 additions & 1 deletion assets/css/search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ header p.header-meta {
.search-field input {
width: 100%;
padding: 15px 20px;
padding-right: 70px;
padding-right: 190px;
border: 2px solid var(--uoft-blue);
border-radius: 12px;
font-size: 16px;
Expand Down Expand Up @@ -363,6 +363,10 @@ header p.header-meta {
font-size: 12px;
color: var(--uoft-blue);
pointer-events: none;
white-space: nowrap;
}

.search-hint kbd {
font-family: monospace;
font-weight: 600;
}
Expand Down
2 changes: 1 addition & 1 deletion assets/js/search/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ export function initControls(onFiltersChange) {

// Update search hint text based on OS
if (navigator.platform.toUpperCase().includes('MAC')) {
document.querySelector('.search-hint').textContent = '⌘K';
document.querySelector('.search-hint kbd').textContent = '⌘K';
}
}
Loading