Repository navigation
Adds suffix removal for Apple Music playlist imports - #217
Merged
Merged
Conversation
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I just found out about this service yesterday and was really interested in getting it set up! I currently use Apple Music and a lot of my playlists are on there, and I remembered that Apple Music will append " - Single / - EP" to albums that aren't full length albums, and a lot of last.fm scrobbling services either have an option to circumvent this or just entirely break scrobbling. I mention this because whenever you import an Apple Music playlist, the metadata is ripped straight from the site and thus, a self-hosted music library (in my case, Jellyfin) will display those album names with the suffixes appended at the end. Because of how Jellyfin handles metadata, this causes a lot of metadata to be skipped and mess up your music library.
With this, I decided to create a function and a toggle to use regular expressions to remove these suffixes from album names before being imported into your music library, allowing for a cleaner library. This optional feature can be toggled in the Settings tab in the frontend but is also an environment variable in the .env file! With that in mind, this is my first time writing in Go and JavaScript, so there may be some things incorrect and I would love to work through any potential issues that may arise.
Thank you for this incredible product and I hope that my contributions make it just a tad bit better!