Skip to content

fix: restore session fork access for Pi runtime overrides - #2029

Merged
Leeeon233 merged 1 commit into
mainfrom
investigate-pi-issue-27
Oct 28, 2026
Merged

Leeeon233 merged 1 commit into
mainfrom
investigate-pi-issue-27

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Related issue

Closes #2023
Companion adapter PR: LodyAI/acp-extension-pi#28

Problem / pressure

Builtin Pi configurations with piPath or piExtensions lost their Fork and Side Chat entry points even when the runtime advertised fork support. The consumers checked source-specific capability entries with undefined runtime overrides.

Summary

  • Resolve the bound Provider configuration when checking Tab, Side Chat and worktree fork availability.
  • Reuse the existing selector authority for edit-and-resend.
  • Extend the mounted Machine Flock test to verify fork availability as configuration and capability rows change.

Visual explanation

Session Provider ID + machine
  → bound Provider runtime overrides
  → matching runtime capability cache
  → Fork / Side Chat / worktree availability

Before / after

Before After
Pi overrides cause a valid fork capability to be hidden Matching Provider overrides preserve the fork entry points
Edit-and-resend repeats the same incorrect check It uses the already-resolved capability authority

Test plan

  • Full pnpm check: typechecks and lint passed, but the test stage stopped at the unchanged CLI test native Git credential adapter > clones recursive native SSH submodules while cloud credentials fail with context_unreadable from the session Git wrapper. CLI totals before stopping: 5,119 passed, 1 failed, 4 skipped.

  • The complete src/lib/github-git-transport.test.ts suite passed when rerun without the ambient session Git wrapper and Git/SSH environment. No Git-transport source was changed; the full root check was not rerun.

  • Components suite: 630 files, 6,431 tests passed.

  • Components typecheck and scoped lint: passed (existing lint warnings).

  • pnpm format and pnpm run docs check: passed.

  • Desktop manual UI verification was not performed.

This host fix is independent of the companion adapter PR. It restores existing native fork access; message-boundary support requires the adapter change to be published and consumed through the managed-runtime release path. This PR does not update the Pi submodule or runtime artifact pin.

@Leeeon233
Leeeon233 marked this pull request as ready for review October 28, 2026 23:19
@Leeeon233
Leeeon233 merged commit 5762178 into main Oct 28, 2026
16 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T23:20:36.632438Z eea5fb7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Leeeon233
Leeeon233 deleted the investigate-pi-issue-27 branch October 28, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Pi 会话无法分叉到新标签页:分叉入口被能力缓存判定错误隐藏

1 participant