Repository navigation
fix: restore session fork access for Pi runtime overrides - #2029
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2023
Companion adapter PR: LodyAI/acp-extension-pi#28
Problem / pressure
Builtin Pi configurations with
piPathorpiExtensionslost their Fork and Side Chat entry points even when the runtime advertised fork support. The consumers checked source-specific capability entries withundefinedruntime overrides.Summary
Visual explanation
Before / after
Test plan
Full
pnpm check: typechecks and lint passed, but the test stage stopped at the unchanged CLI testnative Git credential adapter > clones recursive native SSH submodules while cloud credentials failwithcontext_unreadablefrom the session Git wrapper. CLI totals before stopping: 5,119 passed, 1 failed, 4 skipped.The complete
src/lib/github-git-transport.test.tssuite passed when rerun without the ambient session Git wrapper and Git/SSH environment. No Git-transport source was changed; the full root check was not rerun.Components suite: 630 files, 6,431 tests passed.
Components typecheck and scoped lint: passed (existing lint warnings).
pnpm formatandpnpm run docs check: passed.Desktop manual UI verification was not performed.
This host fix is independent of the companion adapter PR. It restores existing native fork access; message-boundary support requires the adapter change to be published and consumed through the managed-runtime release path. This PR does not update the Pi submodule or runtime artifact pin.