Skip to content

test: add accesssibility checks and fix the violations they found - #96

Merged
vitormattos merged 4 commits into
LibreSign:mainfrom
nva138:feat/playwright-axe
Sep 11, 2026
Merged

test: add accesssibility checks and fix the violations they found#96
vitormattos merged 4 commits into
LibreSign:mainfrom
nva138:feat/playwright-axe

Conversation

@nva138

@nva138 nva138 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Part of #82, the accessibility bit.
Adds the axe check on the main editor state, plus two keyboard tests: can you work the toolbar without a mouse, and is the focus actually visible.

axe turned up five real things, so I just fixed them here, a red check can't merge anyway. The resize handles had no accessible name, the page overlay had an aria-label sitting on a div with no role so screen readers just ignore it, and the demo page was missing a main and an h1 and skipped a heading level.

Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
…landmarks

Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
@nva138
nva138 requested a review from a team as a code owner September 10, 2026 12:09

@vitormattos vitormattos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accessibility tests added here are useful, but they are not running in CI yet.

Since #82 also includes adding Playwright to GitHub Actions, I think it is better to keep this PR open and create a separate PR first for the Playwright CI workflow.

This will also make the code review easier. One PR can focus only on the Playwright setup, and this PR can focus on the accessibility tests and fixes.

After the CI PR is merged, we can update this PR so these tests run as part of the checks.

@nva138

nva138 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

I'll do the CI workflow as a separate PR first and update this one afterwards

Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
@nva138

nva138 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Updated with main, so the Playwright job runs here too.
Also set workers: 1 the suite started failing randomly locally, a different test each run. With one worker it's stable.

@nva138
nva138 requested a review from vitormattos September 11, 2026 10:41
@vitormattos
vitormattos merged commit 7cc02d2 into LibreSign:main Sep 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants