fix: publish screenshot report images from Actions - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end validation of #122 exposed a limitation in the first implementation:
gh pr comment --attachdoes not support GitHub App tokens, including the ActionsGITHUB_TOKEN, so the follow-up workflow failed withunsupported authentication type.This keeps the same trusted
workflow_rundesign, but publishes validated PNG files to a dedicatedscreenshot-reportsbranch and comments with raw image URLs instead.For safety, the workflow only publishes files that are detected as PNG and are no larger than 5 MiB. It still does not check out or execute pull request code in the privileged workflow.
Validation will be repeated with the temporary #123 PR after this lands.