Repository navigation
ci: skip tests and build for release-please PRs and their merges - #36
Open
shauneccles wants to merge 5 commits into
Open
shauneccles wants to merge 5 commits into
shauneccles wants to merge 5 commits into
Conversation
A release bump (changelog, manifest, the package's own version lines in pyproject.toml/uv.lock, plus the __version__ literal) cannot change test outcomes or built artifacts. The 18-cell test matrix and the build job skip it on pull_request and on merges to main; renovate dependency and lock bumps leave foreign anchors or lines and still run everything.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release PR for 0.2.0-style bumps touches CHANGELOG.md, .release-please-manifest.json, the package version line in pyproject.toml and uv.lock, and the
__version__literal — none of which can change test outcomes or wheel bytes. The 18-cell test matrix (3 OS × 6 Python) plus the build job run anyway, then repeat on the merge to main.Fix
A
planjob computesversion_onlyfrom the merge-base diff: true only when every file is release prose or every manifest hunk touches onlyname="audio-hotplug"-anchored version lines.testandbuildskip when set; lint always runs; tags/schedule/manual runs build everything;ci-passedfails if anything non-metadata was skipped without the signal.Same semantics as ledfx-senders#15, samplerate-ledfx#35 and pyfastnoiselite-ledfx#14. Collapses to the shared release-ci action once LedFx/release-ci#15 lands.
Verification: actionlint and zizmor (--min-severity high) clean; detector logic identical to the version already green in the senders repo.