Thevindu-models Dont merge just check only - #25
Open
ThevinduFernando2003 wants to merge 8 commits into
Open
Conversation
Qwen 2.5 3B stays the generator baseline after the 1.5B LoRA failed the gate; shortlist Gemma 2 2B and Phi-3.5 mini as generators, Gemma/Granite as judges, BGE and E5 as embedders, and L-12 plus BGE as rerankers.
Each model-* folder is a fetch/eval/integrate recipe; shared scripts score them on a legal retrieval fixture without changing the live Qwen default.
…faults. Gemma 2 2B and Phi-3.5 Mini appear in GET /api/models only when their GGUFs exist; env.example documents judge, embedder, reranker, and hybrid-agent swaps.
MiniLM already hit perfect Recall@5 on the short corpus, so competing chunks that share keywords were added.
…now. E5-small and MiniLM-L-12 win NDCG on the legal fixture; hybrid ties ANN; GGUF generator/judge evals skipped because no weights were on disk.
…evindu layout. Six root model-* folders and docs/thevindu-models are now one hub with numbered generator, judge, embedding, and RAG directories. Live Qwen default is unchanged.
…n this laptop; retrieval stays MiniLM per real-PDF result
…hevindu test docs for every comparison model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge
thevindu-modelsintomain. This branch records a laptop drop-in bake-off. Live defaults stay where they are.chat_format). Phi must beat Qwen on both metrics — it did not.SystemMessagerejected).chat_agent/+evaluator/files (re-exports of liveintegrated-backend/learnmate, bound to that model id) and Thevindu-style thresholds / checklist / model card / version registry..envwas not edited. No newselectable_default. No GGUF or secrets in this diff (*.gguf/models//.envare gitignored).Decision rules (applied, not implied)
results/real_pdf.json), not the 36-chunk toy fixture.Machine
Windows laptop CPU (
AMD64, Intel Family 6 Model 186), backend venv Python 3.13.7. Not Colab T4. Not uvicorn chat p95. End-to-end chat p95 was not measured (stack was down); retrieve ms must not be labeled as serving p95.Raw evidence
thevindu-models/results/gguf.jsonthevindu-models/results/real_pdf.jsonthevindu-models/results/retrieval.jsonthevindu-models/RESULTS.mdthevindu-models/01_generators/*/RESULTS.md,02_judges/*/RESULTS.md,03_embeddings/*/RESULTS.mdFour-eyes checklist (reviewer: confirm in writing)
selectable_defaultor.envvalue changed anywhere in the diffresults/*.jsonbacks every table number, not just the summary sentenceTest plan
thevindu-models/RESULTS.mdDecision table and §4–§6; check each cell against the JSON filesgit check-ignorestill catchesintegrated-backend/models/*.ggufand.envmodels_registry.yamlstill has onlyqwen25-3basselectable_default: trueintegrated-backend, runeval_components.py(livegenerate_node/Judge) if you want app-prompt numbers inresults/components.json