Repository navigation
Conversation
There was a problem hiding this comment.
Draft intake review at 4fc0ab7e543f68ab62c471f2780b05e3bd8f2974.
The exported statements have the advertised finite loopless multigraph scope. LooplessMultigraph assigns an unordered endpoint pair to each independent edge identity, so parallel edges remain distinct. Proper full colorings assign every edge a color in Fin k; ChromaticIndex is the least such k. The density ranges over odd vertex sets of size at least three and counts internal edges with multiplicity. GeneralHighIndexElementary concludes the stated density equality, and the public bound follows without an additional graph or coloring hypothesis. These are statement and definition checks, not a completed review of the entire port.
The complete public inventory is 729 Lean files and one project card, all additions within the content allowlist. Final acceptance remains pending: the final-head aggregate build and warning/linters/trust checks, preservation of the upstream theorem contracts through the final cleanup, the independent project reviews, and normal protected integration. The earlier build, axiom-audit, contract and timing checkpoints in the description are historical author reports and do not establish those final-head results. Profiling remains advisory.
Keep this draft while its published validation work finishes. No queue or auto-merge action is appropriate at this stage.
Additional maintainability feedback at the same head:
In AbsentOwnerReplacement.lean, helperHNcard363Conditions carries the hierarchy, counterexample, prefix constructions and NineN hypotheses into a bound on the union of two optional colors. Its proof uses only the two optional values and generic finite-set/list cardinality bounds, but the caller must supply the larger proof state. This couples a generic fact to unrelated hierarchy details and makes later changes require unnecessary contract and caller edits. Please express the two-Option cardinality bound as a generic lemma and instantiate it here; check the neighboring suffix-membership helper for the same unnecessary context coupling. This is advisory maintainability feedback.
All 730 published bodies and the complete 729-module import graph are now available and checked for identity, coverage and acyclicity. Full proof-port, semantic and current-head validation acceptance remains pending.
|
/review Please review current head |
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Medium impact] No blocking defect was established in the reviewed repairs, but this partial review does not establish merge readiness. SummaryImports the Goldberg–Seymour bound and high-index density equality for finite loopless multigraphs. The latest repair shares hierarchy, prefix, shortening, and recoloring proofs and removes repeated helper layers.
Reviews (8) · Last reviewed commit: "Integrate concurrent shared Goldberg-Sey..." · Reviewed by Greptile |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed published head f1f8c0a82cccbfb8a5ebb4a64bbd14d80c2a1ed3. The PR is now ready for review, so the earlier draft-readiness note is superseded.
The mathematical scope and provenance review is favorable: the finite loopless multigraph model retains independent edge identities and multiplicity, and the final colouring statement uses the full edge domain. I traced the port against the licensed upstream dependency closure, including the explicit-context and hierarchy-predicate reformulations; I found no added mathematical premise that weakens the claimed theorem.
I also reviewed the complete latest two-file delta. The two new Preamble lemmas prove the natural-number bounds already used by the Fin indices. Replacing the arithmetic proof witnesses preserves the index values and assumptions; the other edits rename unused binders to _ while retaining their types. This does not resolve the separate maintainability suggestion in the earlier review, which remains advisory.
This is a source review, with current-head compilation, trust/quality checks and the configured independent review still to qualify. Author-reported local audits and timing results have not been counted as independent validation. Integration must also wait for the applicable current-main checks and normal protected queue.
|
/review Please run the configured project-rubric review for current published head |
Proof profile (new / modified Lean files)No proof profile output. |
|
/review Please review exact current head The hierarchy-coupled utility finding and neighboring cases are repaired: the two-Option cardinality and final-pair membership facts are generic; the first-missing-position fact is generic; duplicate first-position bounds are shared, with an unnecessary finite-vertex assumption removed. The module shrank from 2,877 to 2,193 lines. Controlled focused runs measured 18.310→16.324 s and 2,293,184→2,013,008 KiB peak RSS. The new Mathlib graph interface converts actual vertex/edge sets to types, proves incidence correspondence, preserves parallel-edge identities and isolated vertices, and exposes the bound without requiring finite ambient types. All 730 modules pass the full public aggregate build without warnings, all 15 native linters, compiler diagnostic export (zero), style, static quality/index/card checks, both complete trust audits, and all 506 original upstream theorem contracts. These local observations are tied to the current source hashes. The exact-head clean timing rerun and CI are pending; independent review and protected integration remain separate requirements. |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed published head 95be6b219559f04be188eba96aeb4a49bf033052.
The new generic two-Option cardinality, final-two-position membership and first-missing-position lemmas address the context-coupling advice in my earlier review. Their callers now supply the facts those lemmas use. The public absent-owner replacement theorem remains unchanged; removing an unused finite-vertex assumption generalizes a private helper.
The Mathlib graph adapter uses the graph’s actual vertex and edge sets, preserving isolated active vertices and distinct parallel-edge identities. Its endpoint/link and incidence correspondence proofs support applying ThmGS to that conversion. The exported bound is stated for the converted graph’s invariants. I also checked the facade, regenerated aggregate and card changes against the complete current source inventory and dependency graph. My source verdict is favorable.
Current-head compilation, trust/quality checks and the configured independent review remain separate requirements. The existing /review request already names this head; older-head checks and author-reported local measurements have not been credited as independent validation. Protected integration still requires the applicable current-main checks and the normal native queue.
Vilin97
left a comment
There was a problem hiding this comment.
Conclusion: approve the source/content at 95be6b219559f04be188eba96aeb4a49bf033052. This is the importing agent’s separate thorough review; it does not replace the configured independent GPT rubric review or authorize integration before that review completes.
The review used the complete local source rather than a truncated patch: all730 files are covered by module/declaration inventories, endpoint signatures, the complete dependency graph, and bounded implementation slices. Foundational graph/coloring/degree/density definitions and176 original data-definition contracts received a separate semantic comparison. All506 original theorem contracts are kernel-proved using the ported declarations. The new graph bridge and the final generic-helper changes were inspected in full.
- Faithfulness:
goldbergSeymourquantifies over arbitrary finite vertex and edge types and every loopless endpoint map. Distinct edge identities retain parallel edges; proper full colorings cover the complete edge domain. Density uses rational division over odd sets of size at least three, with zero included for the empty eligible family.GeneralHighIndexElementarystates the advertised high-index equality. Empty graphs and two-vertex parallel-edge graphs fall within the stated regime. The headline has no undisclosed hierarchy, algorithmic or external-result hypothesis. - Mathlib interface:
graphEndpointPair_eq_iffcharacterizes actual links, andofGraph_incidentproves incidence correspondence. Conversion uses the actual vertex/edge subtypes, including isolated active vertices, so it preserves multiplicity and does not require finite ambient types. The facade exports the bridge and the bound uses the converted graph’s explicitly defined invariants. - Novelty and fit: no existing headline was found in the searched pool cards/source/history/PRs, pinned Mathlib/Tau Ceti combinatorics, or refreshed public code searches. Mathlib’s existing multigraph model motivated the bridge; it is not an existing Goldberg–Seymour proof. Search absence is bounded evidence, not an exhaustive theorem-of-absence. This is completed research-level graph theory with substantial reusable coloring, Kempe, critical-subgraph and Tashkinov infrastructure.
- Sources/license/provenance: the mathematical statement matches Chen–Jing–Zang, arXiv1901.10316v2. The author’s page dates completion October12,2026. Licensed commit88d98c1 explicitly covers Tablet/ under Apache-2.0 and excludes paper/, which is not imported. Wesley Pegden/Trellis attribution and AI provenance are explicit; the new adapter credits Lean Pool contributors.
- Engineering and trust: the hierarchy-coupled Option/cardinality/suffix/first-position helpers are now general facts, and the duplicate first-position bound is shared without an unnecessary finite-vertex assumption.105 repeated arithmetic type witnesses use proved shared bounds. Source budget overrides, diagnostic searches and unstable generated proof references were removed. The full730-module aggregate, all15 native linters, compiler diagnostics (zero), style/index/card/quality checks, both complete trust audits, and506 original contracts pass on matching source hashes. The fixed pool root and all gate/configuration files are unchanged. CI’s Build pool and protected Build project also pass on this head.
Measured cost / quality: 3 of5. The final clean command was LEAN_NUM_THREADS=2 lake build LeanPool.GoldbergSeymour, with private project artifacts removed and exact pinned dependencies warm. Baseline→final:1240.430→1782.543s wall,2019.936→2605.654s child user CPU,282.813→895.614s system CPU,2165628→3407352KiB peak RSS. Whole-project speedup is not established. The shared host was busier;706 modules with identical source and complete project dependency closures had a median1.435 wall-time ratio against the preceding clean checkpoint. That control is descriptive, not a normalized speedup estimate. Focused repairs have measured gains, including39.704→16.457s and6850648→1399832KiB for the shared-index-witness change.
The426,989-line footprint (compatibility baseline224,728) and explicit generated contract plumbing remain real maintenance costs. The interfaces, default-limit proofs, source-strength regression checks and isolated Mathlib adapter make the present source maintainable at the pool’s competent-project bar; this is not a claim of Mathlib-level polish. No further concrete source-blocking finding remains after the repairs. Greptile’s current advisory review reports incomplete full-source coverage, so its green check is not counted as full approval. Independent GPT review and every normal protected native-queue requirement still have to complete.
🤖 LLM review (
|
| Rubric | Verdict | Bottom line |
|---|---|---|
| Faithfulness | ✅ pass |
Both headlines are faithful; no local build was run, four build shards passed with the aggregate result still absent, and advisory profiling failed during cache restoration with disk exhaustion. |
| Novelty | ✅ pass |
No duplicate of either headline was found in the inspected declarations; broader Tau Ceti coverage remains unverifiable, Lean CI remains pending, and advisory profiling failed during cache restoration from disk exhaustion. |
| Significance | ✅ pass |
The Goldberg–Seymour theorem and supporting theory meet the research-level significance bar; no local build was run, hosted assembly/linting remains pending, and advisory profiling failed during cache restoration with disk exhaustion. |
| Sources | ✅ pass |
The cited paper supports the bound and high-index equality, and the Lean explicitly credits Pegden’s pinned Trellis formalization. |
| Code quality (advisory) | 🤔 discuss |
Substantial copied proofs and unused construction premises warrant maintainer review; current-head CI remains incomplete, and advisory profiling failed during cache restoration with disk exhaustion. |
| Aspect | Value |
|---|---|
| Proves the claim | ✅ proves_it |
| Assumed, not proved | Finite vertex and edge types and looplessness; the equality additionally assumes MaximumDegree G + 2 ≤ ChromaticIndex G, as disclosed, while critical cores, removal of isolated vertices, and technical induction contexts are constructed internally. |
| Matches cited source | ✅ matches |
| Fit | ✅ good_fit |
| Level | research |
| Branch | graph theory |
| Mode | theory_building |
| Code quality | 2 / 5 |
Statement check: The Lean proves the advertised bound and high-index equality using proper full edge colorings and rational odd-set density, counting parallel edges separately and including zero when no eligible odd set exists.
GoldbergSeymour.goldbergSeymour establishes ChromaticIndex G ≤ max (MaximumDegree G + 1) (DensityCeil G), the named Goldberg–Seymour bound, supported by substantial critical-subgraph, Kempe-swap and extended Tashkinov-tree theory.
Code quality findings (2)
- duplicate-definition —
LeanPool/GoldbergSeymour/Step1ZeroDividerAnchorNonPE.lean:588
helper_transportExit_758 and Step1ZeroDividerAnchorPE.helper_transportExit_653 have identical proofs after their introductions: the adjacency transport, walk reconstruction and missing-color arguments are independently maintained for two choices of anchor tree. Neighboring pathEdgeOutside helpers repeat this pattern. Further substantial copies remain in the three hseriesStable helpers in TerminalSeriesRebuildTransport/TdTerminalRERebuild and the defective/nondefective confinement branches. Extract proofs over the underlying tree, set and series data, then specialize at callers; otherwise API repairs require synchronized changes across these copies.
Evidence: Bothprivate theorem helper_transportExit_758.{u_1, u_2} :andprivate theorem helper_transportExit_653.{u_1, u_2} :contain identical proof text after introductions, includinghave selectedAlphaEdge : ∀ f : E, Sum.inr f ∈ P.support →,have rebuild : ∀ {s t : Sum V E}, andinduction R with. Likewise, helper_hseriesStable_4663, helper_hseriesStable_6952 and helper_hseriesStable_6436 repeat the proof beginningby_cases hi : i.val < originalPrefix.roundsand endingrw [hilast, hindex, hfinalColor]followed byexact hsigmaStable. - unused-hypothesis —
LeanPool/GoldbergSeymour/ExtensionBaseBranchPreparation.lean:1516
helper_prefixPrefix_4416 proves nesting of two prefixes of an arbitrary A, but requires an extended tree, restoration trace, colors, Kempe walks and unrelated indices. Its proof uses only A and the prefix bounds. ExtensionBaseBranchLemmas forwards this entire unnecessary interface. The neighboring helper_hbeforeZData_4365 similarly couples a basic vertex-order fact to restoration data; ExtensionBaseCaseTwoContradiction.helper_transportStep_250 also carries unused extended-tree and position arguments. Generalize these helpers to their actual tree/coloring inputs and update internal callers to avoid propagating construction context through elementary facts.
Evidence:theorem helper_prefixPrefix_4416.{u_1, u_2} :requires(trace : ExtensionBaseRestorationTrace ett v hvFinal sigma)and(_ : H.Walk (Sum.inl v) (Sum.inl x)). After introductions its entire proof is:
refine ⟨Nat.le_succ q0, ?, ?⟩
· intro i
change A.vertex _ = A.vertex _
congr 1
· intro i
change A.edge _ = A.edge _
congr 1
Tokens: 7,054,398 in / 57,679 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $29.0828 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
CI was not green for this commit at review time; this review does not replace CI.
|
/review Please review exact current head The complete734-module public aggregate builds warning-free; all15 native linters pass22,345 declarations, compiler diagnostics are zero, text style/static quality/generated indexes/card checks pass, both full trust audits pass, and all506 original theorem contracts pass. These records match current source hashes. Focused before/after measurements are in the PR body. A new whole-project clean measurement and exact-head CI remain pending; prior-head CI is not claimed for this revision. No queue or auto-merge action has been taken. |
Vilin97
left a comment
There was a problem hiding this comment.
Source review at 8b8bd48522f16d020e364500412cd608536aec36 is favorable.
I checked all 22 changed source bodies against 95be6b2, with independent reviews of the shared coloring facts, their callers, and the assembly and terminal-data changes. The concrete maintenance findings from review job2350 are addressed: six certificate-case proofs reuse the existing coloring API; the B/C swap proofs retain their weaker hypotheses through shared present-color lemmas; prefix/minimum-position and component facts replace the repeated local arguments; and the four assembly copies now use one transparent constructor.
The existing public theorem headers and structure fields remain unchanged. The 734-module import graph is closed and acyclic, and the project facade, card, dependency pins and checks are unchanged. The retained source, licensing, provenance, significance and scope decisions still apply; no new mathematical or source-quality finding remains from this delta.
This review does not reproduce the author’s local build, trust audit, environment counts or timings. Current-head compiler, lint, style, quality and other required validation remain separate. The completed CI qualification for 95be6b2 is retained only for that older revision. The existing /review request for this new head needs no duplicate.
|
/review Please review exact current head All ten additionally cited certificate analyses use TashkinovSeries.coloringProperties. A generic first-position membership theorem needs only arbitrary tree/coloring/color data, Fintype E and a strict bound; six coupled membership helpers and neighboring bound helpers were removed. The two coupled disjointness helpers were replaced by general Finset facts.61 import headers shed205 imports and added91 narrower imports, preserving private/import-all flags and non-import text; follow-up analysis found no further suggestions. Six new naming-linter findings were fixed without waivers. Current scope:770 modules,418389 physical lines,3301 imports;762 modules in the root closure. This repair cuts5464 net lines. All local checks pass on identical source hashes: complete aggregate1915 jobs with zero warnings,15 native linters over22354 declarations, compiler diagnostics zero, style/static/generated indexes/card resolution, full axiom/option audits and all506 original theorem contracts in17 batches. No checks/configuration changes, waivers or theorem weakening. The final clean two-thread root build passed in1418.949s, user/system CPU2457.981s /305.856s, peak child RSS3,430,692KiB. The compatibility baseline was1240.430s /2,165,628KiB with4341 warnings and source budget overrides, not acceptable content. Both use clean private project artifacts and warm exact dependencies on the same shared16-CPU VM. Raw changes and host-load limitations, all seven focused before/after profiles (including neutral/regressed observations), and scope growth are disclosed in the PR body. No isolated whole-project speedup is claimed. CI on this exact head remains a separate requirement; individual current-head contexts are inspected. The previous8b green CI is not assigned to this revision. Current-head Greptile established no new blocking defect and explicitly reports incomplete coverage. No queue or auto-merge action has been taken. |
|
Partial-port advisory resolution for
The short This resolves the completeness concern represented by this filename/LOC heuristic. No gate, threshold, waiver or challenge statement was changed. Current-head CI and the fresh five-rubric review remain separate requirements; no queue or auto-merge action has been taken. |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed exact head 45810e743d89ee3d7340b11f426cd9bc57a3a655.
The source review is favorable. I reviewed the complete 94-path refactor, including all 36 new shared-fact modules, with independent checks of contracts, moved proofs, constructors, imports and callers. The card, headline theorems and foundational mathematical structures retain the previously reviewed scope and provenance.
The two quality findings from the 8b8bd485 review are addressed across the cited families: the mixed-change, disjoint-theta and extension branches share proved interfaces; certificate branches use the existing coloringProperties; first-position membership now has an arbitrary-tree lemma without the hierarchy reconstruction premises; and the elementary disjointness cases use general Finset facts. Expanded statement aliases and retained callers preserve the original assumptions and conclusions. The two removed public generated helpers are unused and superseded by the general first-position facts.
I found no remaining source blocker in these changes. This is a source judgment, not a build or performance result: the current-head Lean workflow and canonical check remain pending. The existing current-head five-rubric request is retained; older-head CI and review results do not qualify this revision. Protected integration still requires the independent current-head review, complete applicable CI and current-main/native-queue checks.
Vilin97
left a comment
There was a problem hiding this comment.
At 45810e743d89ee3d7340b11f426cd9bc57a3a655, I checked the published review’s remaining quality findings against the actual source. The four core rubric passes remain separate from the advisory quality result.
The remaining repair is concrete: remove six private TwoTwo forwarders and three private prefix helpers; consolidate ten copied segment, missing-leaf, root-swap and adjoin proofs; and replace broad restoration-context arguments in elementary shared facts with narrow premises. The missing-leaf fact must continue to work without assuming distinct colors, and the root-swap fact must not acquire a proper-coloring assumption. Existing public theorem statements and compatibility wrappers must remain available.
I have prepared this bounded cleanup in an isolated worktree based on this exact head. Independent source checks preserve the existing public contracts; compiler and lint validation is still pending, and the published branch has not been changed. The current head’s complete authored checks are qualified, but queue admission remains pending this source repair and the repaired head’s normal checks and review.
|
The filename/LOC advisory on exact head
Descriptive renames, imported preparation modules and shared proof facts account for the observations. The full775-module aggregate, native linters, style, quality, axiom/option audits and original contracts pass locally on matching source hashes. Fresh CI remains pending. No missing theorem was found and no waiver was added. |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed published head b3795278cbdd83738da8e985c700590383ba4fc6.
The complete source delta resolves the earlier quality findings: forwarding layers and copied tree/Kempe/adjoin proofs are replaced by shared facts, and prefix/augmentation transport now uses the data it actually needs. I traced the removed helper interfaces to their replacements and checked the surviving consumers. Port-only helper names have been retired; this is not a claim that every old exported helper name remains available.
The forward missing-neighbor fact still needs no distinct-color hypothesis, and the root-color swap fact adds no proper-coloring hypothesis. Removing the unused finiteness premise from augmentation initial-segment transport strengthens that result. The original mathematical statements, graph bridge, project scope, attribution and provenance remain intact. The complete 775-module aggregate is acyclic and contains all project modules.
My source verdict is favorable for this exact revision. Its current-head hosted validation, configured project review and normal protected integration remain separate requirements. The earlier-head checks and my unpublished targeted repair build are not credited to this head.
|
/review Please run the configured project-rubric review for current published head |
|
The filename/LOC advisory on exact head
Descriptive renames, imported preparation modules and shared proof facts account for the observations. The full775-module aggregate, native linters, style, quality, axiom/option audits and original contracts pass locally on matching source hashes. Fresh CI remains pending. No missing theorem was found and no waiver was added. |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed published head c8299d3aae8f2d347abe5da7db6c5de13dc41fd9.
I checked the complete seven-file continuation. Ten private SplitSwap helpers are replaced by ordinary shared facts about missing-color unions and first missing positions. The original CommonPreparation statement and Conditions are preserved. Prefix congruence keeps the required missing-color witness; its proof correctly combines cutoff equality with bounds on both first positions. Removing unused vertex finiteness from PrefixCutoff strengthens the result.
The four import-only edits retain all non-import code and the required public dependency paths. The complete 775-module aggregate remains acyclic. The mathematical scope, graph bridge, attribution and provenance are unchanged. My source verdict is favorable at this exact head.
The preceding b379527 review and successful checks remain dated evidence. Current-head configured review, authored checks and protected native integration are still required.
|
/review Please run the configured project-rubric review for current published head |
|
/review Please review exact current head |
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed published head 83a7892fd2c13461c8c03ebcbd7c406906574979. The source verdict is favorable after the eleven-path repair.
The three remaining quality findings at c8299d3 are addressed: ten private forwarding layers are removed and callers use the underlying proofs; eight duplicated proof pairs share ordinary proved facts or the existing transport API; and four broad private helpers now take the premises their proofs actually use. Existing public compatibility wrappers retain their assumptions and conclusions. All 107 existing public declaration headers in the changed files are preserved, and the complete 777-module import graph is closed and acyclic. The mathematical headline, graph bridge, card, attribution and provenance are unchanged.
Independent source checks covered the complete changed bodies and callers. Actual local validation passed all 23 targeted modules with the project options, proof-length plugin and warnings treated as errors; target diagnostics were empty. Ten completed targets were reused only after their complete source dependency closures were checked unchanged. This is targeted validation, not a new full-project build or performance claim. No gate or workflow was changed.
This repaired head still needs its own full hosted checks, configured project-rubric review and normal protected integration. The qualified authored CI at c8299d3 remains evidence for that older head; it is not transferred to this revision.
|
/review Please run the configured project-rubric review for current published head |
|
Exact-head partial-port audit at The filename/LOC advisory succeeds but flags16 paths. Each path maps to the actual theorem below and a successful original-statement contract batch on the current source. All506 original theorem contracts pass in17 batches. The proof/preparation imports preserve the complete684-module upstream theorem closure; raw filename/line counts alone are not the completeness evidence.
The full778-module public aggregate, native/compiler/style/static/index/card/trust checks pass locally on matching source hashes. The current clean timing run and current-head Lean CI are still pending; this audit does not replace them. |
|
/review Please review exact current head |
This preserves the completed Goldberg–Seymour theorem for finite loopless multigraphs, including distinct parallel-edge identities:
ChromaticIndex G ≤ max (MaximumDegree G + 1) (DensityCeil G).It also proves the high-index equality
ChromaticIndex G = DensityCeil GwhenMaximumDegree G + 2 ≤ ChromaticIndex G. Odd-set density counts internal edges with multiplicity over odd vertex sets of size at least three. The formalized claims are these mathematical theorems; an executable polynomial-time coloring algorithm is outside the import.Source, eligibility and license
88d98c1d1a59d1f1bf7c4eb58e73f3945f6daf12.Tablet/and excludespaper/; no paper material is imported. Copyright and author attribution are retained.Repository cards, source/history, PRs/issues, pinned Mathlib and Tau Ceti, and refreshed public searches revealed no duplicate of either headline. Public lexical searches supplement the source comparison and are not exhaustive proof of absence.
Scope and reusable mathematics
The coherent upstream theorem closure contains 684
Tabletmodules. The port has 778 Lean modules, 396,766 physical lines and 3,338 direct import edges; the root reaches 770 modules. The complete public aggregate also builds the supporting API modules.The development includes proper partial colorings, Kempe swaps, critical-subgraph reductions, Tashkinov trees, extension sequences and good hierarchies. General facts about tree prefixes, missing colors, hierarchy nesting and certified series are separated from their construction sites. Shared preparation facts sit below their consumers to avoid unnecessary build dependencies.
The Mathlib
Graphbridge uses actual vertex and edge sets as types, proves incidence and endpoint correspondence, preserves isolated active vertices and parallel-edge identities, and supports finite active sets with infinite ambient types.The port targets Lean 4.35.0 and Mathlib 56a005855ea17e0b0958f73ec801ae140b0a1679. It adds one project card and regenerates the public wrapper. Fixed
LeanPool.leanis unchanged, and the diff contains only content.Porting and review repairs
Source heartbeat/recursion overrides were removed, with proofs repaired at the pool’s default limits. Long proofs are decomposed into closed continuations. The port repairs version-sensitive APIs, narrows imports, reduces duplicated elaboration and retains the complete theorem dependency closure.
The final review pass removes 101 verified private forwarding declarations, including chains whose argument order differed. A compiler comparison identified 35 further pairs with identical proof bodies and definitionally equal statements; these now use canonical proofs, general facts or compatibility aliases. Tree-order, first-appearance, missing-position and series-coloring arguments use smaller data interfaces. Public compatibility names refer to a single source of truth for their statements and proofs. A concurrent update of this same author branch is preserved as a merge parent; its shared recoloring and shortening proofs are integrated with the broader cleanup, without rebasing onto main.
All 506 original theorem contracts remain available and recheck in 17 batches. The 176 original definition contracts were compared; 22 generalized or changed interfaces were reviewed individually. Complete compiled-module axiom and option/backdoor audits cover public, private and generated declarations, including aliases. No waiver, suppression, linter change or gate change is included.
The partial-port filename/LOC advisory is checked against the actual declarations and proofs, with its exact-head resolution recorded in the PR comments. Short wrappers import their proof/preparation modules; renamed files retain their results.
Validation at
fccfd814d28756edae5079f48b6e559ae5d1f2faAll local checks passed on identical source hashes: complete public aggregate, zero warnings, 15 native linters, zero compiler diagnostics, style and static quality, generated indexes, card declaration resolution, full axiom/option audits and original theorem contracts. Bounded source review covers every changed module’s endpoint, dependency closure and representative implementation slices, with direct inspection of newly shared and generalized proofs.
Current-head CI: Published fccfd81 current-head CI: seven individual protected contexts pass/legitimately skip. Lean42175973196 has3successful build shards and1running; aggregate protected Build project is not yet present. All10 local phases and the fresh clean root/public aggregate pass with0warnings on778matching source hashes.
Current-head advisory Proof Profile42175973311/job127754518405 failed during Restore pool build. Check annotations confirm System.IO.IOException: No space left on device before source profiling; no CI profile result is claimed. This is not a protected merge gate. Complete local clean and paired measurements are recorded.
Measured compilation
Clean runs use
LEAN_NUM_THREADS=2 lake build LeanPool.GoldbergSeymour, deleting only the isolated worktree’s private.lake/build, with exact dependencies warm and source frozen. The host is a shared 16-CPU VM. This acquisition runs no concurrent Lean work during timing; other host workloads remain uncontrolled. Commands, source hashes, resource records and per-file data are retained on the operator VM.The original compatibility baseline measured 1240.430s wall, 2019.936s user / 282.813s system CPU, peak 2,165,628KiB RSS, over 685 sources / 224,728 lines. It emitted 4,341 warnings and retained source budget overrides, so it was not acceptable content. The preceding
c8299d3aaerevision measured 1470.118s wall / 3,439,628KiB RSS. The larger final scope and explicit dependent interfaces remain a compile-cost and maintenance tradeoff.Final clean root build: 1001.043s wall, 2109.532s user / 294.503s system CPU, maximum child RSS 3,435,456KiB. Host load was 26.96→28.19. Against the original compatibility baseline, the observed wall-time change is -19.3% and peak-RSS change is +58.6%. These shared-host observations are not a causal speedup estimate. The 480 unchanged complete source/dependency closures have median final/c829 per-file ratio 0.833, illustrating timing variation; this is descriptive and is not used to normalize the result.
The paired module measurements below compare byte-identical original
c8299d3aaesources with the repaired sources using the same warm artifact store and common current dependencies, two threads and sequential execution. Original source views retain their original imports, including cached legacy interfaces. Shared-host load is uncontrolled:Direct profiles use
lake env lean --profile --setupwithout artifact output and exclude dependency compilation. The clean Lake build includes root dependencies and artifact generation. All nine paired user-CPU observations are lower; seven wall observations and eight maximum-child-RSS observations are lower. The two disjoint-theta wall regressions are +3.36% and +11.02%; MixedChangeTransport.Preparation2 maximum child RSS rises 0.148%. These module observations do not establish a whole-project speedup; every neutral or regressed measurement is retained.Integration uses the protected native queue after current-head checks, review and applicable current-main validation. Required contexts are inspected individually. Daily asynchronous documentation publishing and advisory profiling are not merge gates; Documentation preflight and every other applicable protected check remain required.