Repository navigation
Conversation
The measure and absolute jobs ran out of space in "Restore pool build" (System.IO.IOException: No space left on device), so every profile comment came back empty. Add the same "Free runner disk space" step main CI already uses, before the dependency and pool-build restores. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Low impact] This PR appears safe to merge. SummaryAdds disk cleanup before cache downloads in
No actionable issues found. Runner disk recovery was not tested during this review. Reviews (1) · Last reviewed commit: "ci(proof-profile): free runner disk befo..." · Reviewed by Greptile |
Proof profile (new / modified Lean files)No added or modified Lean files under Advisory only — never blocks merge. |
Vilin97
left a comment
There was a problem hiding this comment.
{
"assessment": {
"assessment_one_sentence": "The two inserted cleanup steps reuse the exact main-CI command and leave cache identities, measurement inputs, token permissions and advisory reporting unchanged.",
"brittleness": "more_robust",
"introduces_tech_debt": false,
"maintainability": "improved",
"risk": "low",
"scope": "Complete published old/head proof-profile.yml at7c5b98bb7ba663928290250350212e1f23f556ce; infrastructure only."
},
"findings": [],
"summary": "Free fixed hosted-runner tool bundles before restoring dependency and pool-build caches in both advisory profiling jobs. This is a technical source verdict; the repository rule requires separate direct authorization for this PR's workflow changes before protected integration, followed by its normal applicable checks.",
"verdict": "approve"
}
🤖 LLM review — refactor (
|
| Aspect | Value |
|---|---|
| Scope | CI disk cleanup |
| Introduces tech debt | ✅ no |
| Maintainability | ➖ unchanged |
| Brittleness | ➖ unchanged |
| Risk | ✅ low |
The cleanup follows the established CI setup and introduces no actionable maintenance debt.
Tokens: 489,453 in / 4,896 out · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $2.0313 (Standard API equivalent; uncached input) (long-context rate)
Automated review against .github/REFACTOR_REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
The advisory proof profiler fails on every PR: the
Measure head/base NNjobs die in Restore pool build withSystem.IO.IOException: No space left on device(e.g. run 42064834858 on #756/#757), and the comment then reads "No proof profile output.".This adds the same Free runner disk space step that
lean_action_ci.ymlalready uses (removes dotnet, Android SDK, GHC, CodeQL, Swift; printsdf -h /) to the two jobs that restore the pool build —measureandabsolute— right after checkout, before the dependency and pool-build restores. Nothing else changes; theplanandreportjobs don't restore caches.Infra-only; no
LeanPool/**changes. The profiler is advisory, so this doesn't touch any merge gate.Checks:
actionlintclean;pytest tests/test_ci_cache_contract.py tests/test_proof_profile_workflow.py→ 85 passed.Verification: dispatched the profiler from this branch (
workflow_dispatch, so it uses this PR's workflow file) against the two PRs that were failing:Restore pool buildrestored the fullLeanPoolBuild-v1-…cache. The comment now shows the base→head table (12 files, heartbeats 1,846,008 → 2,037,621).An earlier dispatch on #742 also exercised the
absolutejob (cleanup step plus restores) and passed.🤖 Generated with Claude Code