Skip to content

ci(proof-profile): free runner disk before restoring caches - #760

Open
Vilin97 wants to merge 1 commit into
mainfrom
fix/proof-profile-free-disk
Open

Vilin97 wants to merge 1 commit into
mainfrom
fix/proof-profile-free-disk

Conversation

@Vilin97

@Vilin97 Vilin97 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The advisory proof profiler fails on every PR: the Measure head/base NN jobs die in Restore pool build with System.IO.IOException: No space left on device (e.g. run 42064834858 on #756/#757), and the comment then reads "No proof profile output.".

This adds the same Free runner disk space step that lean_action_ci.yml already uses (removes dotnet, Android SDK, GHC, CodeQL, Swift; prints df -h /) to the two jobs that restore the pool build — measure and absolute — right after checkout, before the dependency and pool-build restores. Nothing else changes; the plan and report jobs don't restore caches.

Infra-only; no LeanPool/** changes. The profiler is advisory, so this doesn't touch any merge gate.

Checks: actionlint clean; pytest tests/test_ci_cache_contract.py tests/test_proof_profile_workflow.py → 85 passed.

Verification: dispatched the profiler from this branch (workflow_dispatch, so it uses this PR's workflow file) against the two PRs that were failing:

An earlier dispatch on #742 also exercised the absolute job (cleanup step plus restores) and passed.

🤖 Generated with Claude Code

The measure and absolute jobs ran out of space in "Restore pool build"
(System.IO.IOException: No space left on device), so every profile
comment came back empty. Add the same "Free runner disk space" step
main CI already uses, before the dependency and pool-build restores.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict.

RetriggerView in Greptile

[Low impact] This PR appears safe to merge.

Summary

Adds disk cleanup before cache downloads in measure and absolute.

  • Proof-profile jobs clear runner disk before restoring Lean caches.

No actionable issues found. Runner disk recovery was not tested during this review.

Reviews (1) · Last reviewed commit: "ci(proof-profile): free runner disk befo..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Proof profile (new / modified Lean files)

No added or modified Lean files under LeanPool/ in this PR. No compile-cost measurements are needed.

Advisory only — never blocks merge.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"assessment": {
"assessment_one_sentence": "The two inserted cleanup steps reuse the exact main-CI command and leave cache identities, measurement inputs, token permissions and advisory reporting unchanged.",
"brittleness": "more_robust",
"introduces_tech_debt": false,
"maintainability": "improved",
"risk": "low",
"scope": "Complete published old/head proof-profile.yml at7c5b98bb7ba663928290250350212e1f23f556ce; infrastructure only."
},
"findings": [],
"summary": "Free fixed hosted-runner tool bundles before restoring dependency and pool-build caches in both advisory profiling jobs. This is a technical source verdict; the repository rule requires separate direct authorization for this PR's workflow changes before protected integration, followed by its normal applicable checks.",
"verdict": "approve"
}

@Vilin97 Vilin97 added the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Nov 5, 2026
@Vilin97

Vilin97 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 LLM review — refactor (gpt-6.1-sol)

Reviewed head: 7c5b98bb7ba663928290250350212e1f23f556ce

Verdict: ✅ approve

Adds the existing CI disk cleanup before dependency and pool-build restores in both profiling jobs. The commands match lean_action_ci.yml; Lean sources, cache contracts, and job conditions remain unchanged. All 85 targeted tests and cleanup shell syntax checks passed. Hosted-runner disk recovery remains unverified; actionlint was unavailable locally.

Aspect Value
Scope CI disk cleanup
Introduces tech debt ✅ no
Maintainability ➖ unchanged
Brittleness ➖ unchanged
Risk ✅ low

The cleanup follows the established CI setup and introduces no actionable maintenance debt.


Tokens: 489,453 in / 4,896 out · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $2.0313 (Standard API equivalent; uncached input) (long-context rate)
Automated review against .github/REFACTOR_REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant