Repository navigation
Add project structure section to README - #1805
Merged
Merged
Conversation
…lidate persisted settings The README-only change was not the real fix. This lands the actual implementation and regression tests from LabsCrypt#1814: - useStreamingAmount: treat a non-finite or negative ratePerSecond as 0 so NaN can never leak into the rendered claimable (drip) amount. - useSettings: validate persisted decimalPlaces, displayCurrency and amountFormat on hydration and in the synchronous getters, falling back to the documented defaults (7, USD, full) for invalid stored values. - Tests: streaming amount pause/rate boundary coverage, malformed and partial SSE frame recovery, reconnect timer/listener cleanup, and invalid settings fallback cases. Closes LabsCrypt#1781 Closes LabsCrypt#1782 Closes LabsCrypt#1783 Closes LabsCrypt#1784 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original README-only change did not address the linked issues. This PR now carries the actual fix (implementation and regression tests reused from #1814):
useStreamingAmount: a non-finite or negativeratePerSecondis treated as0, soNaNcan never leak into the rendered claimable (drip) amount.useSettings: persisteddecimalPlaces,displayCurrencyandamountFormatare validated on hydration and in the synchronous getters, falling back to the documented defaults (7,USD,full) for invalid stored values.Verification
next buildand bundle-size check: passedCloses #1781
Closes #1782
Closes #1783
Closes #1784