Parameterize tests that loop over DbScopes - #7994
Open
labkey-tchad wants to merge 1 commit into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
labkey-tchad
force-pushed
the
fb_externalDataSourceTesting_cleanup
branch
from
August 28, 2026 21:39
e0cefa3 to
80fa6a1
Compare
labkey-tchad
force-pushed
the
fb_externalDataSourceTesting_cleanup
branch
from
August 29, 2026 05:05
80fa6a1 to
60c65cd
Compare
DialectTestCase, GroupConcatTestCase, and Method.TestCase each looped over every DbScope in one @test method, so a failure on one scope aborted every scope after it; each now runs as an independent JUnit case per scope via a shared JunitUtil.getDbScopesTestParameters() helper. Split out LabKeyScopeDialectTestCase and Method.IsDistinctFromMethodTestCase for the test methods that never depended on the loop, since JUnit's Parameterized runner requires every test in the class to share the same constructor; registered both new classes in CoreModule/QueryModule.
labkey-tchad
force-pushed
the
fb_externalDataSourceTesting_cleanup
branch
from
August 29, 2026 05:10
60c65cd to
3cc0526
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialectTestCase, GroupConcatTestCase, and Method.TestCase each looped over every DbScope in one @test method, so a failure on one scope aborted every scope after it; each now runs as an independent JUnit case per scope via a shared JunitUtil.getDbScopesTestParameters() helper.
Split out LabKeyScopeDialectTestCase and Method.IsDistinctFromMethodTestCase for the test methods that never depended on the loop, since JUnit's Parameterized runner requires every test in the class to share the same constructor; registered both new classes in CoreModule/QueryModule.
Stack created with GitHub Stacks CLI • Give Feedback 💬