Repository navigation
docs(karpor): note that the Ingress needs Kubernetes 1.19+ - #133
Merged
elliotxx merged 1 commit intoOct 20, 2026
Merged
Conversation
The Ingress template uses networking.k8s.io/v1, which Kubernetes added in 1.19. Say so in the values and the README, as suggested in the review of KusionStack#132. Bump the chart to 0.7.8. Co-authored-by: Iamrushabhshahh <rushabhshah842@gmail.com> Signed-off-by: Iamrushabhshahh <rushabhshah842@gmail.com>
Contributor
Author
Contributor
Author
|
Gnetle follow up on this @elliotxx 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Follow-up to #132. @elliotxx suggested noting that the Ingress needs Kubernetes 1.19+, because the template uses
networking.k8s.io/v1.charts/karpor/values.yaml: theingress.enabledcomment now says it needs Kubernetes 1.19+.charts/karpor/README.md.gotmpl: the Ingress section says it uses thenetworking.k8s.io/v1API and needs Kubernetes 1.19 or later.charts/karpor/README.md: regenerated with helm-docs.charts/karpor/Chart.yaml: version 0.7.7 to 0.7.8.No template changes.
How I tested it
helm lint charts/karpor: 1 chart linted, 0 failed.helm template t charts/karpor --set ingress.enabled=truerenders the same Ingress as before.Related: KusionStack/karpor#808
@elliotxx, could you take a look when you have time?