Conversation
since `refCounts` member contains object with type `Resource` calling: `refCount[id]++` was incorrect. This PR fixes this issue. However it also rises a question if we want to keep ref count within the `Resource` object or simply use `int` as a value of the `refCounts` member variable.
Update resource existence check to verify resource ID.
Updated resource management implementation to improve type safety and reference counting. Made the code more coherent and cleared some ambiguities
Contributor
Author
|
The rest of the code in the tutorial is structured with assumption that std::unordered_map<std::string, ResourceData> refCounts;I have altered the tutorial where it mattered to match this assumption. Furthermore some clarification was needed like for example why one needs |
Refactor resource release logic to use DecreaseRefCount method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since
refCountsmember contains object with typeResourcecalling:refCount[id]++was incorrect.This PR fixes this issue. However it also rises a question if we want to keep ref count within the
Resourceobject or simply useintas a value of therefCountsmember variable.so basically there are two choices either we`ll have:or
std::unordered_map<std::type_index, std::unordered_map<std::string, int>> refCounts;The second approach would work with what was initially in the tutorial. Either way is fine so if you have time please let me know which version is better and I will alter this PR respectively.Based on the rest of the tutorial it seems that niether of those types are correct and instead it is supposed to be
Thank you !