Repository navigation
Decode character references above U+FFFF correctly - #251
Merged
Peter Gromov (donnerpeter) merged 1 commit intoOct 20, 2026
Merged
Peter Gromov (donnerpeter) merged 1 commit into
Peter Gromov (donnerpeter) merged 1 commit into
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
Peter Gromov (donnerpeter)
approved these changes
Oct 20, 2026
Peter Gromov (donnerpeter)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityConverter.replaceEntitiesconverted the decoded code point withInt.toChar(), which truncates anything above U+FFFF.😀rendered as U+F600 and𝔄as프; this affects every numeric reference outside the BMP and the 133 named entities above U+FFFF.Changes:
Compat.codePointToString, so supplementary code points become a proper surrogate pair.�, surrogate code points and values above U+10FFFF with U+FFFD, as the CommonMark spec requires.�stays literal text.Tests:
EntityConverterTestincommonTestfor decimal, hex and named references above U+FFFF, invalid code points and over long references.data/html/entities.txthad captured the old output for� �(a truncatedand a raw NUL byte); it now expects&#98765432; �, matching the spec../gradlew jvmTest jsTest wasmJsTestpasses locally. I could not run the native targets (no Xcode on this machine); the change is in common code only.Fixes #250