feat(web): rework the whats-new audiences section into a pinned stage - #2154
Open
lumberman wants to merge 2 commits into
Open
feat(web): rework the whats-new audiences section into a pinned stage#2154lumberman wants to merge 2 commits into
lumberman wants to merge 2 commits into
Conversation
Rewrites the page copy for its actual reader — a missionary or ministry partner whose workflow broke and who is looking for why — and rebuilds the audiences section around the question that copy is trying to land. Copy: leads with what changed and where to report breakage, drops the sections that told the reader they are a rounding error, and replaces the promise-shaped paragraph with what has actually shipped and what is being built now. The ministry share is one constant interpolated everywhere it appears, so a corrected figure cannot leave the page stating two numbers about the same audience. Audiences stage: the three cards enter as a staircase hanging below the row and rise into it, hold there assembled and still, then two fade out while the third travels into the first column and the estimate question arrives beside it. The section heading is inside the pin, so it holds with the cards it names and leaves with them. Also: the assistant phone uses the real ChatGPT app icon, the FAQ gets the "tell us" card as a sidebar, and the history-of-formats arc moves up to second on the page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lumberman
force-pushed
the
feat/watch-whats-new-audience-stage
branch
from
September 3, 2026 01:02
42bc356 to
82b9ef9
Compare
|
🚅 Deployed to the forge-pr-2154 environment in forge
8 services not affected by this PR
|
CI's `format` and `lint (@forge/web)` jobs both flagged one object literal in `whats-new-content.ts`. Verified with the jobs' own commands, `pnpm run format:check` and `pnpm --filter @forge/web lint`, rather than a Prettier run over the handful of files edited most recently — which is what let this through. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2027. Rewrites the
/watch/whats-newcopy for its actual reader and rebuilds the audiences section around the question that copy is trying to land.Copy
Written for a missionary or ministry partner whose workflow broke and who is looking for why — irritated or curious, non-technical — with org leadership as the secondary reader.
<time datetime>(a test keeps the two on the same day).Audiences stage
The three cards now enter as a staircase hanging below the row and rise into it; hold there assembled, level and opaque; then two fade out while the third travels into the first column and the estimate question arrives beside it.
That hold did not previously exist — the fade began at
contain 0%while the gather was still closing, so the finished row was never once on screen undisturbed. Measured at 1440x900: 475px of assembled row (375px of it pinned-still), with 525px of dwell left after the question lands for actually dragging the slider.The section heading moved inside the pin, so it holds with the cards it names and leaves on their beat rather than scrolling away and leaving three cards and a question with nothing labelling them.
Also
WhatsNewSelfIdandWhatsNewAudienceCardBodyremoved.Verification
tsc --noEmit,next build, Prettier — clean.next build+next start, nevernext dev).display, letting the heading outlive the cards — each goes red).Notes for review
contain a% b%out of the media block in source order and destructured positionally, so adding a rule above another silently reassigned every name. It now looks each range up by selector.aria-labelledbytarget, sodisplay/visibilitywould drop the section's accessible name partway down the page. Its box keeps its space; that leaves ~142px of empty band above the question, which is the deliberate cost of not reflowing the pinned group mid-hold.apps/web/public/images/whats-new/chatgpt-app-icon.pngis a third-party trademarked asset. Flagging for a call on whether vendoring it is acceptable here.🤖 Generated with Claude Code