Skip to content

update minObserved in Sync test #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasperGeurtz merged 1 commit into from
Oct 31, 2026
Merged

update minObserved in Sync test #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<version>2.22.2</version>
<configuration>
<rerunFailingTestsCount>10</rerunFailingTestsCount>
<argLine>-Xms1g -Xmx1g</argLine>
<argLine>-Xms768m -Xmx768m</argLine>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -117,7 +117,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine> --add-opens java.base/java.nio=ALL-UNNAMED </argLine>
<argLine>-Xms768m -Xmx768m --add-opens java.base/java.nio=ALL-UNNAMED</argLine>
</configuration>
</plugin>

Expand Down
4 changes: 3 additions & 1 deletion src/test/java/bwapi/SynchronizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ public void async_MeasurePerformance_CopyingToBuffer() {
.build();
SynchronizationEnvironment environment = new SynchronizationEnvironment(config);
environment.runGame(20);
final double minObserved = 0.25;
assertTrue("Copy to buffer: minimum must be positive",
environment.metrics().getCopyingToBuffer().getRunningTotal().getMin() > 0);
final double minObserved = 0;
final double maxObserved = 15;
final double meanObserved = (minObserved + maxObserved) / 2;
final double rangeObserved = (maxObserved - minObserved) / 2;
Expand Down
Loading