Repository navigation
Preview: Micro-move 100 is a whole step, as in the firmware - #30
Merged
Merged
Conversation
The firmware splits a step into 48 ticks and maps Micro-move 0...100 onto 1...48 of them (mtSequencer.cpp in polyend/tracker-ce), so 100 is a whole step late. The preview used half a step, an estimate from the manual. Closes #26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #26. The preview moved a Micro-moved note half as far as the Tracker does.
In the firmware source (polyend/tracker-ce,
core/source/mtSequencer.cpp):map(value + 1, 0, 100, 1, 48), so 100 is 48 ticks, one whole step.PreviewRenderer.microMoveSpangoes from the estimated 0.5 to 1.0. The comment now cites the source, and the line inAGENTS.mdno longer calls the span an estimate.How to test
cd PatternautCore && swift test: 156 tests. The Micro-move test now checks that 100 starts a whole step late and 50 starts half a step late.Checklist
cd PatternautCore && swift test)App/project.ymlor sources changed (no new files)🤖 Generated with Claude Code