Conversation
nelsonic
reviewed
Oct 12, 2019
nelsonic
left a comment
nelsonic
left a comment
There was a problem hiding this comment.
This PR seems like a good idea.
There are a lot of duplicates in the file.
Test it easily for yourself.
Open https://github.com/JamesFT/Database-Quotes-JSON/blob/master/quotes.json
and search for the first quote: "Genius is one percent inspiration"
You'll see it is repeated 4 times in the file:
Same goes for most of the quotes ... 🤔
|
Anyone needing a curated list of quotes without duplicates, see: https://github.com/dwyl/quotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.