Skip to content

Fix union of quoted property names returning no results #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix union of quoted property names returning no results #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6548957
Fix union of quoted property names returning no results
spokodev Jul 23, 2026
5918240
Merge upstream main; re-apply the quoted-union property strip in _trace
spokodev Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/jsonpath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,8 +837,12 @@ class JSONPathClass {
} else if (loc.includes(',')) { // [name1,name2,...]
const parts = loc.split(',');
for (const part of parts) {
// Strip the quotes that survive tokenization of a quoted union
// member (e.g. $['x','y'] leaves parts ["x'", "'y"]); bare and
// numeric members have no quotes and are unaffected.
const prop = part.trim().replace(/^['"]|['"]$/gu, '');
addRet(this._trace(
unshift(part, x),
unshift(prop, x),
val,
path,
parent,
Expand Down
7 changes: 7 additions & 0 deletions test/test.properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ checkBuiltInVMAndNodeVM(function (vmType, setBuiltInState) {
assert.deepEqual(result, expected);
});

it('Union of quoted property names', () => {
const data = {x: 1, y: 2, z: 3};
assert.deepEqual(jsonpath({json: data, path: "$['x','y']"}), [1, 2]);
assert.deepEqual(jsonpath({json: data, path: '$["x","y"]'}), [1, 2]);
assert.deepEqual(jsonpath({json: data, path: "$['x', 'y']"}), [1, 2]);
});

it('At signs within properties', () => {
let result = jsonpath({json, path: "$.datafield[?(@.tag=='035')]", wrap: false});
assert.deepEqual(result, [json.datafield[0]]);
Expand Down