Repository navigation
Prevent hang by using non blocking reads - #30
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
============================================
- Coverage 90.74% 90.70% -0.04%
Complexity 605 605
============================================
Files 58 58
Lines 2324 2325 +1
============================================
Hits 2109 2109
- Misses 215 216 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a process outputs content to
stderrandstdoutis flagged as readable but without any content then iterating over$process->output()will hang forever and the process will be blocked by filling up itsstderrbuffer.This happens because when fagged readable the process will read its content in a blocking way, however since there's no data it will wait forever for any data to arrive. But there will be no data since the process outputs to
stderronly.The precise reason why
stdoutis flagged as readable even though there's no data is not understood for now (that's why there's no anti regression test).Solution
Read
stdout/stderrin a non blocking way.Note
Since the precise reason is not understood, this fix should be treated as an extra caution for something that might happen.