Repository navigation
Keep warm-path deploys terminated during model load - #440
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436
#437 fixed the linker (deploys that wait for a new node). This covers the warm path: deploys onto a node that is already ready, where
place_and_provisionloads the model directly.What changed in
place_and_provision:update_state(..., unless_in=ENDED_STATES). If it's skipped because the deploy was terminated during the load, the model is unloaded on the worker and no endpoint is published.error_message, like the linker.Testing:
test_terminate_during_warm_load_is_not_overwritten(load ok and load failed): a terminate lands insideload_modelon a node where another deploy holds 2 GPUs. It fails on main (RUNNING / FAILED over TERMINATED) and passes here; the other deploy's GPUs stay allocated.test_deploy_endpoint_pool_first.pyis on CI's ignore list, so I ran it against a Postgres container with the repo schema. The other 22 failures in that file are the same on main (missingX-Organization-IDheader since Check pool ownership and take new owners from the caller's org #417). Linker and worker lifecycle tests still pass.Not changed: when RUNNING is skipped, the API response still reports DEPLOYING (the DB row is TERMINATED), same as the linker.