Repository navigation
Only offer deploys pools can run - #438
Merged
Priyanshu-u07 merged 2 commits intoOct 25, 2026
Merged
Priyanshu-u07 merged 2 commits into
Priyanshu-u07 merged 2 commits into
Conversation
Priyanshu-u07
approved these changes
Oct 25, 2026
Priyanshu-u07
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Speech nodes now ask for an external deployment instead of offering a Deploy that can't start, image generation uses inferia-diffusion with the same spec as New Deployment, and a failed deploy shows "Deploy failed" with a working Retry instead of staying on "Deploying…"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433
Why
The canvas offered Deploy for speech and image nodes with engines that no compute pool can run (speaches, generic). The deploy could not start, and since the canvas only lists READY/RUNNING deployments, the node stayed on "Deploying..." forever.
What changed
inferia-diffusion, using the same job spec New Deployment builds (buildDiffusionSpec)./deployment/status/{id}for each deploy it started. If the deploy ends FAILED, TERMINATED or STOPPED, the node shows "Deploy failed" with the error and a Retry button.Scope
Verification
inferia-diffusionwith its image, and a FAILED status turns into "Deploy failed" plus Retry within one poll.