Repository navigation
Fix fourth-order TDVP sweep directions - #226
Open
osvathbotond wants to merge 1 commit into
Open
osvathbotond wants to merge 1 commit into
osvathbotond wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix fourth-order TDVP evolution, which currently throws a
BoundsErroron the third substep.sub_time_steps(::TDVPOrder{4})defines six substeps, butorderings(::TDVPOrder{4})supplies only two sweep directions. Repeat the forward/reverse direction pair three times to match the three symmetric second-order stages encoded by the existing coefficients.Minimal demonstration of previous behavior
Minimal demonstration of new behavior
How Has This Been Tested?
Added
test/base/test_solvers/test_tdvp_orders.jl:All 136 assertions passed locally on Julia 1.13.0 after formatting:
Formatter idempotence was also verified. The full repository test suite has not been run locally.
Checklist