docs: what production assurance means for a native client - #533
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- keys.KeyCustody.Durable was written for a server: tokens and cached JWKS surviving a restart. For a client it means a key outlives the process that made it until the client is done with it, so an in-progress authorization or a DPoP-bound token survives a restart. The doc now says so, with a native app's per-flow platform-keystore keys as an example that qualifies. - client's AssuranceProduction refusal of a Random that isn't crypto/rand.Reader now says to pass it directly rather than a wrapper, which nothing can verify. - storage.Capabilities.AtomicConsume says a mutex suffices for a store one process uses, and not for one other processes open too, such as an app extension sharing the app's data container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
osanderson
force-pushed
the
docs/client-native-assurance
branch
from
October 3, 2026 12:52
d6a69f9 to
d47e035
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is point 3 of the native-wallet asks.
client.AssuranceProduction's three checks hold for a native client, but their docs were written for a server, and two of them caught a wallet out.keys.KeyCustody.Durablespoke only of tokens and cached JWKS surviving a restart. For a client, it now says,Durablemeans a key outlives the process that made it until the client is done with it: an in-progress authorization can be completed after a restart, and a DPoP-bound token stays usable. A native app's per-flow keys held in the platform key store (the iOS Keychain or Secure Enclave, the Android Keystore) qualify, so embedders can declare it honestly.crypto/rand.Readeritself, not a wrapper, which is the trap gomobile-bound packages fall into.AtomicConsume: for a store used by one process, such as a native app's own session store, a mutex around the read and the delete is enough. A store another process also opens, such as an app extension or widget sharing the app's data container, needs a file lock or the database's own transaction.No behaviour changes beyond the error's wording.
Tests
go testfor client, keys, storage and server passes, and golangci-lint is clean.🤖 Generated with Claude Code