Repository navigation
Conversation
… set The dashboard's pending-decision queue is a rule-separated band instead of a card, settings keeps three cards with the notification preferences inside Account & access, and admin keeps five: the console header is a header, pending approvals sit at the top of the user card, and release, backups and retention share one maintenance card. test/layout.test.ts counts the exact class="card" attribute and caps the three pages at 4, 3 and 5, each strictly below the base it was measured on (5, 4, 9); the empty dashboard at exactly 4 stays the control. docs/ui.md records the three ceilings, and mock/ is regenerated with npm run mock:snapshot.
HugoXK-bot
requested changes
Nov 21, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES at 539c8a5
docs/architecture.md:177-180still says/settingsdraws "four group cards …#notifications" and that its nav is "four links, one per.card[id]in draw order". At this tip/settingsrenders three exactclass="card"surfaces (account-access,model-providers,feedback) with#notificationsa.subinside#account-access(src/views/pages.ts:2807), so the four chips are three card chips plus one sub-block chip. That contradicts the paragraph this commit fixes atdocs/architecture.md:157-170anddocs/ui.md:86-88("/settingsat 3 (base 4)").- Fix (docs only): say three group cards on
:177, add#notificationsto the#account-accesssub-block list on:178, and on:179describe the nav as card chips in draw order plus the grouped sub-block chips. - Non-blocking:
docs/architecture.md:158-159"a chip for each grouped sub-block that keeps anid" reads as every id-bearing sub-block, but#account,#sessionsand#tokenskeep ids and have no chip — "each former card now grouped into a sub-block" would be exact.
Ran: npx tsx --test test/layout.test.ts test/sectionNav.test.ts (27/27 pass at this tree); tsx render probe: exactclass="card"counts empty dashboard 4, busy dashboard 4, settings 3, admin 5, andid="actions-needed"still renders on the busy dashboard.
Not run: fullnpm run checklocally (CIci-oksuccess136724764120at this tip);mock:checklocally (CImock-checksuccess136723986392); no pixel inspection of the 24evidence/659PNGs — all 24 URLs resolve but I read no images.
Written-by: HugoXK-bot
added 2 commits
November 21, 2026 04:24
The grouped pages give admin a header instead of a card and add chips for sub-blocks inside a card, so the paragraph that said one chip per card is no longer true. Name the sub-block targets, the topic ordering, and the first chip.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: HugoXK
Author: Fledge Platform Dev-3
Commit identity:
commit.authorandcommit.committerare bothFledge Platform Dev-3 <dev3@fledge.invalid>, read back fromGET /repos/HugoXK/fledge/commits/7bf06478b596b1cc7ffdc96beeabcf87e5526d5bafter the push.Fixes #659
What a user sees differently
Before.
/dashboardstacked one ruled section per area, so a reader with one pending decision met five cards before reaching the delivery numbers: setup, "Needs your decision", delivery, repositories and jobs./settingsdrew four cards, and/admindrew nine — including a full-width card that held nothing but the page's own title.After. The same routes, controls, data and copy in fewer surfaces.
/dashboarddraws four cards, and the pending-decision queue is a rule-separated band in the flow instead of a card of its own./settingsdraws three, with the notification preferences as a sub-block of Account & access./admindraws five: the console header is a header, pending approvals sit at the top of the user card, and release, backups and retention share one maintenance card — that card carries a new "Maintenance / 维护" chip in the section nav, and the existing release, backups and retention chips still jump inside it.The counting rule and the measured numbers
A card is an occurrence of the exact attribute
class="card"— not theclass="card…"prefix and not acardclass token.class="quota-card card",class="card notices"andclass="card provider-card"are real, differently styled surfaces, so under either looser rule a fix could drop a class name and keep the box./dashboard/dashboard/settings/adminWhat the fifth card actually is. On the busy dashboard the exact count is five because four plain cards are joined by the pending-action queue; the notification banner renders
class="card notices", a compound class the exact-attribute counter never matches. That is why the seat's three columns read 5 / 8 / 9 (exact / prefix / tokens) on that fixture: the banner moves only the two looser columns. The previousdocs/ui.mdsentence said the banner made the fifth card and this PR corrects that attribution in the doc.Two assertions close the holes the count alone leaves open. First, the busy fixture must still contain
id="actions-needed": ifactionsstopped being honoured the busy page would fall to four and both the ceiling and the control would pass on a false green. Second, reclassifying has to remove the chrome, not the name: plain.cardis a transparent box with a 1px top rule, so the test now asserts that.bandpaints no background, no shadow and no border except its ownborder-left, and that.subpaints no background, no shadow and no border at all — the separator lives on.sub + .sub.The control sentence also runs the other way round from the original card: a conditional-only fix does pass the ceiling, because the empty page stays at 4. What the empty page at exactly 4 pins is the four real surfaces (setup, delivery, repositories, jobs): removing one of those fails, while removing the conditional card does not.
Red first, at
f1c48ed3In a clean worktree at
f1c48ed3513a8180b870fae19fb95d32222da44b— this branch's parent — with only the committedtest/layout.test.tscopied in,npx tsx --test test/layout.test.tsgives 16 tests, 14 pass, 2 fail, and the two failures name the work:The control assertion in the same file — the empty dashboard at exactly 4 — passes at the base by design, which is what makes it a control rather than a third red row. The copy that ran there is byte-identical to the committed file (
test/layout.test.tssha2566c7111e694956ca19833e3cb03c71e7c1926789e04356b8f8c95b206146f846b), so nothing was edited after the red run.At the tip
7bf06478b596b1cc7ffdc96beeabcf87e5526d5bthat file is 16/16, and withtest/sectionNav.test.tstogether 27/27.What changed
src/views/pages.ts#actions-neededis<section class="band">instead of a card. Settings: the#notificationsblock moves inside#account-accessas a<section class="sub">. Admin: the console header card becomes<header class="page-head">,#pendingbecomes a sub-block at the top of the#userscard, and release/backups/retention become sub-blocks of one#maintenancecard; its nav chip is added between Audit and Release.public/app.css.page-head(no top rule, section gap only),.band(a 1px left rule instead of a section rule),.sub + .subgeneralised from the settings shell so grouped panels separate the same way, and one scroll-margin rule so an anchor nested inside a card still clears the section nav.test/layout.test.tsNotificationRowandActionRow; the queue-presence assertion; the empty dashboard as the control; and the chrome assertion for.bandand.sub.test/sectionNav.test.tsnotificationsis placed as a topic after Models although it sits inside the account card, andpendingleads the admin page although it sits inside the users card.docs/ui.mdchangelog.d/659.changed.mdmock/*.html,mock/assets/app.cssnpm run mock:snapshot; no hand edits.Alternatives considered
class="card…"prefix or thecardtoken. Rejected: the compound classes (quota-card card,card notices,card provider-card) are differently styled surfaces, so a fix could pass the ceiling by renaming a card rather than removing one./dashboardto ≤ 3 on the empty fixture. Rejected: the seat's CHANGES ate893d038aaf3asked for one of two things, and naming the fixture that renders the fifth card keeps the ceiling measured against the base it is compared to.#maintenanceand a chip instead.notificationsbelongs after Models in a reader's order even though it renders inside the account card, andpendingleads the admin page even though it renders inside the users card. The card chips are the ordered list; the test says so and the comment says why.Uncertainty and residual risk
<h2>; adding one would have changed copy the card asked to keep./dashboardand/settingsonly;/admin's 9→5 is verified by the count test and the screenshots, not by a regenerated mock snapshot — its markup is asserted directly throughadminPage.Ran:
npx tsx --test test/layout.test.tsin a clean worktree atf1c48ed3with only the committed test file copied in — 16 tests, 14 pass, 2 fail:card ceilings: dashboard 5/4, settings 4/3, admin 9/5and.band keeps only its own left rule(actual[], expected['border-left']); the control passes.npx tsx --test test/layout.test.tsat the tip — 16/16;npx tsx --test test/layout.test.ts test/sectionNav.test.ts— 27/27.npm run checkat the tip — exit 0: lint11 warning(s) in 8 entries match the baseline,tsc --noEmitclean, 3266 tests / 3266 pass / 0 fail, build clean.npm run mock:check—mock-snapshot: ok (14 files).node scripts/risk-gate.mjs --base f1c48ed3513a8180b870fae19fb95d32222da44bat the tip — output below.Not run:
npm run visual:matrixfrom this box (its CI job runs it): the local browser cache here carries the headless shell only, and the matrix's own gate pass is the job's evidence, not a local one.docs/deploy.mdchange (a docs card is in flight) and nothing on#1016.The basis is a regenerated mock snapshot, which the rule set places at T2 by default rather than by name; the page renderer itself (
src/views/pages.ts) is listed T2 above. It needs a PASS at this tip.Branch state
Three commits on
dev3/659-card-ceilings, parentf1c48ed3513a8180b870fae19fb95d32222da44b(livemain, the#1184release fix). The first carries the grouping, its test,docs/ui.md, the changelog fragment and the regenerated mocks; the second and third are docs-only and correctdocs/architecture.md— the nav paragraph, then the/settingsparagraph, which still called#notificationsa fourth card when it is a sub-block inside#account-access. The first commit was built on25d0c459and rebased ontof1c48ed3before the branch was ever pushed, so there is no merge commit and nothing was force-pushed.#1184toucheddocs/deploy.md,scripts/release-open.mjsandtest/releaseOpen.test.ts; none of the three overlaps this diff, andgit diff 25d0c459 f1c48ed3 -- src/views public mockis empty.Risk and rollback
Rollback: revert this commit. Nothing is stored, migrated or routed differently; every page returns to its previous markup and the mock snapshots to their previous bytes. The only reader-visible loss is the grouping itself.
Docs and changelog
Docs updated:
docs/ui.mdrecords the three ceilings next to the spacing scale, anddocs/architecture.mdnow describes the nav the grouped pages actually draw — card chips in card order plus topic-ordered chips for grouped sub-blocks,/adminopening with a header rather than a card, and/settingsdrawing three cards with#notificationsas a sub-block inside#account-access. Changelog:changelog.d/659.changed.md.Before / after frames
Chromium, full page,
deviceScaleFactor: 1, light, the same seeded development user on both sides (dashboard: one unread notification and one pending action — the fixture the ceiling is measured on). Before ismain25d0c459d0b4a69a55e5884769cf0eb90f79f46d, the commit before#1184; the rendered inputs are byte-identical atf1c48ed3(git diffempty forsrc/views,publicandmock), so these frames are what the branch's own base renders. After is this tip7bf06478b596b1cc7ffdc96beeabcf87e5526d5b.document.scrollWidth - innerWidthis 0 in every frame. Images live on theevidence/659branch (images only, no PR, not for merge); the file names under that branch match the URLs below.English:
/dashboard/settings/adminChinese:
/dashboard/settings/admin