Skip to content

docs(deploy): name the flag reading that refuses a reused pull request - #1189

Open
HugoXK wants to merge 1 commit into
mainfrom
dev2/1185-deploy-flag-readback
Open

HugoXK wants to merge 1 commit into
mainfrom
dev2/1185-deploy-flag-readback

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Written-by: Fledge Platform Dev-2

Fixes #1185

What changed

docs/deploy.md:497-499 summarised the release opener's reuse refusals as "a flag that does not read back" — the absent readback, which #575 protects as a reuse — while both the sentence four lines below (:502-505) and the code (scripts/release-open.mjs:284-286) refuse on the flag reading back true, and on nothing else. The clause now says "a flag that reads back true".

Nothing else changes: flattening the file before and after leaves the text identical apart from that one clause, so :502-505 and the owner-close paragraph at :505-509 are untouched.

test/deployDoc.test.ts is new and carries the card's four assertions, in the card's order and against whitespace-normalised text (the phrase wrapped a line at the base, so a raw line grep reads zero even when the sentence is there):

  1. the flattened text does not contain a flag that does not read back — red at the base;
  2. the flattened text contains a head in another repository, a flag that reads back `true`, or a readback that cannot be made is a refusal rather than a reuse — red at the base;
  3. the precise sentence a readback that reports `maintainer_can_modify: true` survives — a guard, green at the base;
  4. maintainer_can_modify: false never appears — a guard, green at the base.

Red first, at the base

f1c48ed3513a8180b870fae19fb95d32222da44b, with the new test file dropped onto an otherwise untouched checkout:

$ npx tsx --test test/deployDoc.test.ts
# tests 4
# pass 2
# fail 2

The failures are assertions 1 and 2. Assertions 3 and 4 pass at the base by design and are not claimed as red evidence.

At the tip:

$ npx tsx --test test/deployDoc.test.ts
# tests 4
# pass 4
# fail 0

Risk tier

node scripts/risk-gate.mjs --base origin/main at the tip, verbatim:

T1: test/deployDoc.test.ts
T0: docs/deploy.md
risk-tier: T1; basis: test/deployDoc.test.ts

Docs plus one file under test/, so T1, and green ci-ok is the whole gate. No src/ change, no code path touched.

UI surface

None. The diff is one sentence in a runbook and one test file; there is no page, control or string a user can see, so there is no before/after frame to take.

Docs and changelog

This change is the doc, so no Docs-not-needed: line. No changelog.d/ fragment: a runbook sentence a user cannot observe is not a user-visible change per AGENTS.md.

Uncertainty and residual risk

Assertion 1 only guards docs/deploy.md. That is the surface the card names and the only file carrying the sentence, but a future doc that restates the refusal elsewhere would not be covered by this file's test.

Rollback

Revert the single commit: it changes one clause in docs/deploy.md and adds test/deployDoc.test.ts. Nothing depends on either at runtime.

Ran:

  • npx tsx --test test/deployDoc.test.ts at f1c48ed3513a8180b870fae19fb95d32222da44b — 4 tests, 2 passed, 2 failed (the red above)
  • npx tsx --test test/deployDoc.test.ts at the tip — 4 tests, 4 passed, 0 failed
  • npm run check at the tip — exit 0 (# tests 3268 / # pass 3268 / # fail 0, lint and typecheck clean, build ok)
  • node scripts/risk-gate.mjs --base origin/main at the tip — risk-tier: T1; basis: test/deployDoc.test.ts
  • a flattened before/after comparison of docs/deploy.md — identical apart from the replaced clause

Not run:

  • no release-opener run and no GitHub API call: scripts/release-open.mjs and test/releaseOpen.test.ts are untouched, and this is a docs-and-test diff
  • no browser or screenshot: no UI surface
  • scripts/visual-matrix.ts, scripts/mock-snapshot.ts, Docker image build, real SMTP

The release runbook's summary described the maintainer_can_modify refusal
backwards — a flag that does not read back — while the sentence four lines
below and scripts/release-open.mjs:284-286 both refuse on the flag reading
true. #575 settled the other two shapes: an omitted key and false are reuses.

One clause changes; the precise sentence and the owner-close paragraph stay as
they were. test/deployDoc.test.ts pins the three refusals and the two readings
that are not refusals, normalising whitespace because the phrase wraps a line.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(deploy): the release opener's reuse summary inverts the maintainer_can_modify refusal

1 participant