Repository navigation
Conversation
The release runbook's summary described the maintainer_can_modify refusal backwards — a flag that does not read back — while the sentence four lines below and scripts/release-open.mjs:284-286 both refuse on the flag reading true. #575 settled the other two shapes: an omitted key and false are reuses. One clause changes; the precise sentence and the owner-close paragraph stay as they were. test/deployDoc.test.ts pins the three refusals and the two readings that are not refusals, normalising whitespace because the phrase wraps a line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Fledge Platform Dev-2
Fixes #1185
What changed
docs/deploy.md:497-499summarised the release opener's reuse refusals as "a flag that does not read back" — the absent readback, which#575protects as a reuse — while both the sentence four lines below (:502-505) and the code (scripts/release-open.mjs:284-286) refuse on the flag reading backtrue, and on nothing else. The clause now says "a flag that reads backtrue".Nothing else changes: flattening the file before and after leaves the text identical apart from that one clause, so
:502-505and the owner-close paragraph at:505-509are untouched.test/deployDoc.test.tsis new and carries the card's four assertions, in the card's order and against whitespace-normalised text (the phrase wrapped a line at the base, so a raw line grep reads zero even when the sentence is there):a flag that does not read back— red at the base;a head in another repository, a flag that reads back `true`, or a readback that cannot be made is a refusal rather than a reuse— red at the base;a readback that reports `maintainer_can_modify: true`survives — a guard, green at the base;maintainer_can_modify: falsenever appears — a guard, green at the base.Red first, at the base
f1c48ed3513a8180b870fae19fb95d32222da44b, with the new test file dropped onto an otherwise untouched checkout:The failures are assertions 1 and 2. Assertions 3 and 4 pass at the base by design and are not claimed as red evidence.
At the tip:
Risk tier
node scripts/risk-gate.mjs --base origin/mainat the tip, verbatim:Docs plus one file under
test/, so T1, and greenci-okis the whole gate. Nosrc/change, no code path touched.UI surface
None. The diff is one sentence in a runbook and one test file; there is no page, control or string a user can see, so there is no before/after frame to take.
Docs and changelog
This change is the doc, so no
Docs-not-needed:line. Nochangelog.d/fragment: a runbook sentence a user cannot observe is not a user-visible change per AGENTS.md.Uncertainty and residual risk
Assertion 1 only guards
docs/deploy.md. That is the surface the card names and the only file carrying the sentence, but a future doc that restates the refusal elsewhere would not be covered by this file's test.Rollback
Revert the single commit: it changes one clause in
docs/deploy.mdand addstest/deployDoc.test.ts. Nothing depends on either at runtime.Ran:
npx tsx --test test/deployDoc.test.tsatf1c48ed3513a8180b870fae19fb95d32222da44b— 4 tests, 2 passed, 2 failed (the red above)npx tsx --test test/deployDoc.test.tsat the tip — 4 tests, 4 passed, 0 failednpm run checkat the tip — exit 0 (# tests 3268 / # pass 3268 / # fail 0, lint and typecheck clean, build ok)node scripts/risk-gate.mjs --base origin/mainat the tip —risk-tier: T1; basis: test/deployDoc.test.tsdocs/deploy.md— identical apart from the replaced clauseNot run:
scripts/release-open.mjsandtest/releaseOpen.test.tsare untouched, and this is a docs-and-test diffscripts/visual-matrix.ts,scripts/mock-snapshot.ts, Docker image build, real SMTP