Repository navigation
Sprint 7 · M5: Settings page (change password, privacy, theme) + O9 clearCookie fix - #70
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SumitGauswami
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Sprint 7 · M5: adds a Settings page, opened from the sidebar and the account menu, with change password (old password required, other sessions logged out), the privacy switches moved here from My profile, and a theme choice. Also fixes O9, the
res.clearCookiedeprecation inauth.js.User stories / requirements: Sprint 7 M5 (Settings page), O9
Changes
/settings(SettingsPage.jsx), opened from the sidebar under My profile, the account menu, the command palette or the shortcut G then S. It has four sections: Account, Change password, Privacy, Appearance.POST /api/settings/password(newroutes/settings.js, rules inlib/passwordChangeRules.js)code: "current_password_wrong", not 401, so a typo does not sign the user out.ThemeContext.jsxnow supportssystem. The top-bar toggle and the "T" shortcut still work.maxAge. Express 4.21+ warns about this, and it also kept an empty cookie in the browser for 7 days. Every clear inauth.jsnow goes through one helper (clearRefreshCookie) withoutmaxAge, so the cookie is deleted immediately.app.js(mounts/api/settings),realtime.js(sockets store their session ID; newdisconnectOtherSessions),api.js(settingsApi),App.jsx,AppShell.jsx,ProfilePage.jsx,styles.csssprint7-settings.spec.js. The Sprint 5 privacy E2E now uses/settings.How to test it
/settingsand the breadcrumb says Settings.res.clearCookie: Passing "options.maxAge" is deprecatedwarning.Checklist
mainand mergedmainagain just before opening this PRnpm testpasses inbackend/andfrontend/npm run buildpasses infrontend/npm run lintshows no errors (run in the repository root)npm run format -- <file> <file>(repository root).envfiles,node_modulesordistin the diffScreenshots (UI changes)